ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] ascherbakoff commented on a change in pull request #6546: IGNITE-11848: New Monitoring. Phase1
Date Thu, 13 Jun 2019 09:45:07 GMT
ascherbakoff commented on a change in pull request #6546: IGNITE-11848: New Monitoring. Phase1
URL: https://github.com/apache/ignite/pull/6546#discussion_r293290607
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/metric/IoStatisticsHolderCache.java
 ##########
 @@ -48,12 +50,23 @@
 
     /**
      * @param cacheName Name of cache.
+     * @param grpId Group id.
+     * @param mreg Metric registry.
      */
-    public IoStatisticsHolderCache(String cacheName, int grpId) {
+    public IoStatisticsHolderCache(String cacheName, int grpId, MetricRegistry mreg) {
         assert cacheName != null;
 
         this.cacheName = cacheName;
         this.grpId = grpId;
+
+        MetricRegistry mset = mreg.withPrefix(CACHE_GROUP.metricGroupName(), cacheName);
 
 Review comment:
   I think mreg, mset is not very descriptive, check RULE2 of abbreviation rules.
   reg or registry are more descriptive variants for MetricRegistry instance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message