ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6483: IGNITE-5714 Implementation of suspend/resume for pessimistic transactions
Date Mon, 10 Jun 2019 09:04:29 GMT
alex-plekhanov commented on a change in pull request #6483: IGNITE-5714 Implementation of suspend/resume
for pessimistic transactions
URL: https://github.com/apache/ignite/pull/6483#discussion_r291933570
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMvcc.java
 ##########
 @@ -1331,12 +1331,31 @@ public void remove(GridCacheVersion ver) {
     @Nullable public GridCacheMvccCandidate localCandidate(UUID nodeId, long threadId) {
         if (locs != null)
             for (GridCacheMvccCandidate c : locs)
-                if (c.nodeId().equals(nodeId) && c.threadId() == threadId)
+                if (c.nodeId().equals(nodeId) && c.isHeldByThread(threadId))
                     return c;
 
         return null;
     }
 
+    /**
+     * Near local candidate.
+     *
+     * @param nodeId Node ID.
+     * @param threadId Thread ID.
+     * @param ver Lock version.
 
 Review comment:
   Such a description is commonly used all over the class for this parameter, I don't see
a reason to make an exception here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message