ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] daradurvs commented on a change in pull request #6546: IGNITE-11848: New Monitoring. Phase1
Date Thu, 06 Jun 2019 20:05:26 GMT
daradurvs commented on a change in pull request #6546: IGNITE-11848: New Monitoring. Phase1
URL: https://github.com/apache/ignite/pull/6546#discussion_r291345463
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/metric/ReadOnlyMetricRegistry.java
 ##########
 @@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.spi.metric;
+
+import java.util.Collection;
+import java.util.function.Consumer;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Read only metric registry.
+ */
+public interface ReadOnlyMetricRegistry {
+    /**
+     * @param prefix prefix for all metrics.
+     * @return Proxy implementation that will search and create only metrics with specified
prefix.
+     */
+    public <T extends ReadOnlyMetricRegistry> T withPrefix(String prefix);
+
+    /**
+     * Prefixes combined using dot notation {@code ["io", "stat"] -> "io.stat"}
+     *
+     * @param prefixes prefixes for all metrics.
+     * @return Proxy implementation that will search and create only metrics with specified
prefixes.
+     */
+    public <T extends ReadOnlyMetricRegistry> T withPrefix(String... prefixes);
+
+    /**
+     * @return Metrics stored in this group.
+     */
+    public Collection<Metric> getMetrics();
 
 Review comment:
   Not sure if it's a good idea to return the metrics outside or not.
   As I can see in the implementations code changes a state of the collections event the interface
called 
    *ReadOnly*MetricRegistry.
   I think it would be better to encapsulate such actions like 'reset', 'add' etc 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message