ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] daradurvs commented on a change in pull request #6546: IGNITE-11848: New Monitoring. Phase1
Date Thu, 06 Jun 2019 20:05:26 GMT
daradurvs commented on a change in pull request #6546: IGNITE-11848: New Monitoring. Phase1
URL: https://github.com/apache/ignite/pull/6546#discussion_r291343529
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metric/MetricNameUtils.java
 ##########
 @@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.metric;
+
+/**
+ * Utility class to build or parse metric name in dot notation.
+ *
+ * @see GridMetricManager
+ * @see MetricRegistry
+ */
+public class MetricNameUtils {
+    /** Metric name part separator. */
+    public static final String SEPARATOR = ".";
+
+    /**
+     * Example - metric name - "io.statistics.PRIMARY_KEY_IDX.pagesCount".
+     * root = io - JMX tree root.
+     * subName = statistics.PRIMARY_KEY_IDX - bean name.
+     * msetName = io.statistics.PRIMARY_KEY_IDX - prefix to search metrics for a bean.
+     * mname = pagesCount - metric name.
+     *
+     * @param name Metric name.
+     * @return Parsed names parts.
+     */
+    public static MetricName parse(String name) {
+        int firstDot = name.indexOf('.');
+        int lastDot = name.lastIndexOf('.');
+
+        String grp = name.substring(0, firstDot);
+        String beanName = name.substring(firstDot + 1, lastDot);
+        String msetName = name.substring(0, lastDot);
+        String mname = name.substring(lastDot + 1);
+
+        return new MetricName(grp, beanName, msetName, mname);
+    }
+
+    /**
+     * Builds metric name. Each parameter will separated by '.' char.
+     *
+     * @param names Metric name parts.
+     * @return Metric name.
+     */
+    public static String metricName(String... names) {
+        assert names != null;
+        assert ensureAllNamesNotEmpty(names);
+
+        if (names.length == 1)
+            return names[0];
+
+        return String.join(SEPARATOR, names);
+
+    }
+
+    /**
+     * Asserts all arguments are not empty.
+     *
+     * @param names Names.
+     * @return True.
+     */
+    private static boolean ensureAllNamesNotEmpty(String... names) {
+        for (int i=0; i<names.length; i++)
+            assert names[i] != null && !names[i].isEmpty() : i + " element is empty
[" + String.join(".", names) + "]";
+
+        return true;
+    }
+
+    /**
+     * Parsed metric name parts.
+     *
+     * Example - metric name - "io.statistics.PRIMARY_KEY_IDX.pagesCount".
+     * root = io - JMX tree root.
+     * subName = statistics.PRIMARY_KEY_IDX - bean name.
+     * msetName = io.statistics.PRIMARY_KEY_IDX - prefix to search metrics for a bean.
+     * mname = pagesCount - metric name.
+     */
+    public static class MetricName {
 
 Review comment:
   The class should be top-level from my point of view since it's public and static.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message