From notifications-return-3555-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon May 27 09:33:52 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7634D180638 for ; Mon, 27 May 2019 11:33:52 +0200 (CEST) Received: (qmail 91611 invoked by uid 500); 27 May 2019 09:33:51 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 91602 invoked by uid 99); 27 May 2019 09:33:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 May 2019 09:33:51 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] ibessonov commented on a change in pull request #6528: IGNITE-11346 Message-ID: <155894962867.28859.3582608840812150017.gitbox@gitbox.apache.org> Date: Mon, 27 May 2019 09:33:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ibessonov commented on a change in pull request #6528: IGNITE-11346 URL: https://github.com/apache/ignite/pull/6528#discussion_r287717722 ########## File path: modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java ########## @@ -1085,7 +1085,7 @@ else if (spiState == LOOPBACK_PROBLEM) { */ private void localAuthentication(SecurityCredentials locCred){ assert spi.nodeAuth != null; - assert locCred != null; +// assert locCred != null; Review comment: Are you sure that this won't break anything? This variable is passed into "authenticateNode" after this line and I believe that this method may not expect null value. Please clarify this moment and either remove comment or return this assert back. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services