ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] pavlukhin commented on a change in pull request #6434: IGNITE-11708 "Unable to run tests in IgniteConfigVariationsAbstractTest subclasses"
Date Thu, 30 May 2019 11:59:52 GMT
pavlukhin commented on a change in pull request #6434: IGNITE-11708 "Unable to run tests in
IgniteConfigVariationsAbstractTest subclasses"
URL: https://github.com/apache/ignite/pull/6434#discussion_r288962053
 
 

 ##########
 File path: modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java
 ##########
 @@ -92,22 +73,17 @@
     @Override public String getTestIgniteInstanceName() {
         return "testGrid";
     }
-
-    /**
-     * Invoked by reflection from {@code ConfigVariationsTestSuiteBuilder}.
 
 Review comment:
   I think that we can add a comment to `testsCfg` fields stating that it is assigned by generated
code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message