ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] ibessonov commented on a change in pull request #6528: IGNITE-11346
Date Mon, 27 May 2019 09:33:48 GMT
ibessonov commented on a change in pull request #6528: IGNITE-11346
URL: https://github.com/apache/ignite/pull/6528#discussion_r287717722
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
 ##########
 @@ -1085,7 +1085,7 @@ else if (spiState == LOOPBACK_PROBLEM) {
      */
     private void localAuthentication(SecurityCredentials locCred){
         assert spi.nodeAuth != null;
-        assert locCred != null;
+//        assert locCred != null;
 
 Review comment:
   Are you sure that this won't break anything? This variable is passed into "authenticateNode"
after this line and I believe that this method may not expect null value. Please clarify this
moment and either remove comment or return this assert back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message