ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] EdShangGG commented on a change in pull request #6500: IGNITE-10913
Date Tue, 21 May 2019 17:04:23 GMT
EdShangGG commented on a change in pull request #6500: IGNITE-10913
URL: https://github.com/apache/ignite/pull/6500#discussion_r286127949
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/file/FilePageStore.java
 ##########
 @@ -59,7 +61,16 @@
     public static final int HEADER_SIZE = 8/*SIGNATURE*/ + 4/*VERSION*/ + 1/*type*/ + 4/*page
size*/;
 
     /** */
-    private final File cfgFile;
+    private volatile File cfgFile;
 
 Review comment:
   I strongly recommend removing this field completely. 
   I have gone through all usages and all of them: on errors, on initialization.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message