ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] pavlukhin commented on a change in pull request #6434: IGNITE-11708 "Unable to run tests in IgniteConfigVariationsAbstractTest subclasses"
Date Tue, 21 May 2019 10:57:58 GMT
pavlukhin commented on a change in pull request #6434: IGNITE-11708 "Unable to run tests in
IgniteConfigVariationsAbstractTest subclasses"
URL: https://github.com/apache/ignite/pull/6434#discussion_r285966824
 
 

 ##########
 File path: modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java
 ##########
 @@ -108,9 +92,17 @@ protected static void injectTestsConfiguration(VariationsTestsConfig
testsCfgInj
         return false;
     }
 
+    /** Check that test name is not null. */
+    @Before
+    public void checkTestName(){
+        assert getName() != null : "getName returned null";
+    }
+
     /** {@inheritDoc} */
     @Override protected void beforeTestsStarted() throws Exception {
-        assert testsCfg != null;
+        assert testsCfgInjected != null;
+
+        testsCfg = testsCfgInjected;
 
 Review comment:
   @1vanan I suppose it is expected to work as follows:
   1. Test classes are created using a code generation library.
   2. `testsCfgInjected` (static member) is assigned on `@BeforeClass` level.
   3. `testsCfg` (instance member) is assigned on `@Before` level.
   
   A test class instance is created for each test method execution. So, I do not understand
how an expected configuration is injected to each test instance. Could you please that configurations
are injected as expected? I suspect that `dummyCfg` is injected everywhere now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message