ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] EdShangGG commented on a change in pull request #6330: IGNITE-11592 NPE in case of continuing tx and cache stop operation
Date Mon, 20 May 2019 13:11:24 GMT
EdShangGG commented on a change in pull request #6330: IGNITE-11592 NPE in case of continuing
tx and cache stop operation
URL: https://github.com/apache/ignite/pull/6330#discussion_r285580475
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxEntry.java
 ##########
 @@ -934,9 +935,10 @@ public void unmarshal(GridCacheSharedContext<?, ?> ctx, boolean
near,
         if (this.ctx == null) {
             GridCacheContext<?, ?> cacheCtx = ctx.cacheContext(cacheId);
 
-            assert cacheCtx != null : "Failed to find cache context [cacheId=" + cacheId
+
-                ", readyTopVer=" + ctx.exchange().readyAffinityVersion() + ']';
-
+            if (cacheCtx == null)
+                throw new CacheInvalidStateException(
 
 Review comment:
   Also, does it mean that we do not distinguish cache destroy and cache restart? And would
throw stop exception in both situations?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message