ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] Jokser commented on a change in pull request #5765: IGNITE-10078 Node failure during concurrent partition updates may cause partition desync between primary and backup.
Date Tue, 14 May 2019 13:17:57 GMT
Jokser commented on a change in pull request #5765: IGNITE-10078 Node failure during concurrent
partition updates may cause partition desync between primary and backup.
URL: https://github.com/apache/ignite/pull/5765#discussion_r283721508
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##########
 @@ -1815,8 +1817,8 @@ private void processSinglePartitionUpdate(final ClusterNode node, final
GridDhtP
 
         try {
             if (msg.exchangeId() == null) {
-                if (log.isTraceEnabled())
-                    log.trace("Received local partition update [nodeId=" + node.id() + ",
parts=" +
+                if (log.isInfoEnabled())
 
 Review comment:
   A number of single messages with exchangeId==null can be very high and string representation
of msg can be long, I think the log level should be returned to trace or debug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message