From issues-return-99223-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Sep 30 07:38:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E945C180656 for ; Mon, 30 Sep 2019 09:38:03 +0200 (CEST) Received: (qmail 74723 invoked by uid 500); 30 Sep 2019 07:38:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 74659 invoked by uid 99); 30 Sep 2019 07:38:03 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Sep 2019 07:38:03 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 25FD3E30FA for ; Mon, 30 Sep 2019 07:38:02 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 5DD4A7807B0 for ; Mon, 30 Sep 2019 07:38:00 +0000 (UTC) Date: Mon, 30 Sep 2019 07:38:00 +0000 (UTC) From: "Alexei Scherbakov (Jira)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (IGNITE-12209) Transaction system view MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940709#comment-16940709 ] Alexei Scherbakov edited comment on IGNITE-12209 at 9/30/19 7:37 AM: --------------------------------------------------------------------- [~nizhikov] Note what org.apache.ignite.internal.processors.cache.transactions.IgniteTxState#allEntries and org.apache.ignite.internal.processors.cache.transactions.IgniteTxState#cacheIds are unsynchronized and tx state can be concurrently updated if a transaction enlists keys in the moment of view producing. So current implementation is unsafe but probably will work somehow. I suggest to enclose methods in try .. catch(Throwable) to implement fallback in case something goes wrong. was (Author: ascherbakov): [~nizhikov] Note what org.apache.ignite.internal.processors.cache.transactions.IgniteTxState#allEntries and org.apache.ignite.internal.processors.cache.transactions.IgniteTxState#cacheIds are unsynchronized and can be concurrently updated if a transaction enlists keys in the moment of view producing. So current implementation is unsafe but probably will work somehow. I suggest to enclose methods in try .. catch(Throwable) to implement fallback in case something goes wrong. > Transaction system view > ----------------------- > > Key: IGNITE-12209 > URL: https://issues.apache.org/jira/browse/IGNITE-12209 > Project: Ignite > Issue Type: Sub-task > Affects Versions: 2.7.6 > Reporter: Nikolay Izhikov > Assignee: Nikolay Izhikov > Priority: Major > Labels: IEP-35 > Fix For: 2.8 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > IGNITE-12145 finished > We should add transactions to the system views. -- This message was sent by Atlassian Jira (v8.3.4#803005)