ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Diana Iakovleva (Jira)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-11815) Get rid of GridTestUtils.retryAssert method.
Date Thu, 12 Sep 2019 06:46:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928281#comment-16928281
] 

Diana Iakovleva commented on IGNITE-11815:
------------------------------------------

[~amashenkov] I've updated PR, can you please take a look?

> Get rid of GridTestUtils.retryAssert method.
> --------------------------------------------
>
>                 Key: IGNITE-11815
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11815
>             Project: Ignite
>          Issue Type: Test
>            Reporter: Andrew Mashenkov
>            Assignee: Diana Iakovleva
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain, newbie
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> For now we have GridTestUtils.retryAssert() method which runs a closure 'n' times to
check if some invariantes become ok, eventually.
> This method catch assertion error (this looks like a very bad idea) and can print them
to log many times even if assertion is acceptable for the moment.
>  Also, it is possible to miss an assertion is not related to those ones that closure
checks  (e.g. assertion error thrown from ignite internals).
> Let's replace retryAssert with GridTestUtils.waitForCondition() usage to make logs clearer
and to avoid possible false positive results.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message