From issues-return-98079-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Aug 23 13:18:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1966A180637 for ; Fri, 23 Aug 2019 15:18:04 +0200 (CEST) Received: (qmail 62780 invoked by uid 500); 23 Aug 2019 13:18:01 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 62768 invoked by uid 99); 23 Aug 2019 13:18:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Aug 2019 13:18:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E81F7E30B1 for ; Fri, 23 Aug 2019 13:18:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 2E70B780C2C for ; Fri, 23 Aug 2019 13:18:00 +0000 (UTC) Date: Fri, 23 Aug 2019 13:18:00 +0000 (UTC) From: "Maxim Muzafarov (Jira)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (IGNITE-1236) Create a checkstyle definition and hook it into the Maven build MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-1236?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated IGNITE-1236: ------------------------------------ Labels: checkstyle (was: ) > Create a checkstyle definition and hook it into the Maven build > --------------------------------------------------------------- > > Key: IGNITE-1236 > URL: https://issues.apache.org/jira/browse/IGNITE-1236 > Project: Ignite > Issue Type: Improvement > Components: build > Reporter: Ra=C3=BAl Kripalani > Assignee: Ra=C3=BAl Kripalani > Priority: Major > Labels: checkstyle > > The community has put together a comprehensive set of coding guidelines h= ere: https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines. > We need a checkstyle definition that we can enforce automatically via the= Maven Checkstyle plugin. > We can choose to output violations as warnings, or to fail the build if v= iolations exist. At this point I would prefer the former to avoid "stopping= the world". With such a large codebase it is likely that checkstyle violat= ions are already present. > This will help contributors adequate their style to the community's stand= ard while they are coding, and will reduce frustration otherwise caused by = submitting pull requests that do not satisfy guidelines, and having to rect= ify them at a later stage. -- This message was sent by Atlassian Jira (v8.3.2#803003)