ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Muzafarov (Jira)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-1236) Create a checkstyle definition and hook it into the Maven build
Date Fri, 23 Aug 2019 13:22:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914258#comment-16914258
] 

Maxim Muzafarov commented on IGNITE-1236:
-----------------------------------------

[~raulvk], hello!

It seems to me I've missed this issue and all the work by enabling checkstyle plugin under the
IGNITE-11277 issue. Can I close the current issue as duplicate? 

I've marked all the issued related to checkstyle configuration with the label `checkstyle`,
so no one will be missed. Please, also feel free to create an issue to support a new checkstyle
rule.

> Create a checkstyle definition and hook it into the Maven build
> ---------------------------------------------------------------
>
>                 Key: IGNITE-1236
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1236
>             Project: Ignite
>          Issue Type: Improvement
>          Components: build
>            Reporter: Raúl Kripalani
>            Assignee: Raúl Kripalani
>            Priority: Major
>              Labels: checkstyle
>
> The community has put together a comprehensive set of coding guidelines here: https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines.
> We need a checkstyle definition that we can enforce automatically via the Maven Checkstyle
plugin.
> We can choose to output violations as warnings, or to fail the build if violations exist.
At this point I would prefer the former to avoid "stopping the world". With such a large codebase
it is likely that checkstyle violations are already present.
> This will help contributors adequate their style to the community's standard while they
are coding, and will reduce frustration otherwise caused by submitting pull requests that
do not satisfy guidelines, and having to rectify them at a later stage.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message