ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Pavlukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-11708) Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
Date Wed, 29 May 2019 09:13:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850652#comment-16850652
] 

Ivan Pavlukhin commented on IGNITE-11708:
-----------------------------------------

[~ivanan.fed], approach without _static_ variable looks simpler for me as well. Now we assign
a configuration in Ignite _before_ callbacks in order to be sure that the configuration is
accessible during each stages of a test execution. But can we inject a configuration in a
generated test class constructor (for the same purposes)? In my mind it will make things even
more simpler because it requires injection only in one place and guarantees that an injected
configuration is accessible on any stage of test execution (regardless what callbacks are
used, Ignite of junit). What do you think?

> Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
> --------------------------------------------------------------------
>
>                 Key: IGNITE-11708
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11708
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Ivan Fedotov
>            Assignee: Ivan Fedotov
>            Priority: Major
>              Labels: iep30
>         Attachments: read_through_eviction_self_test.patch, tx_out_test_fixed.patch
>
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> It seems that test classes that extend from IgniteConfigVariationsAbstractTest cannot
be started with JUnit4 @Test annotation. 
> It is easy to check: if throw exception in any test methods, nothing will happen.
> Reason can be in rule chain in IgniteConfigVariationsAbstractTest class [1], maybe it
destroys existing test workflow.
> [1] https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java#L62



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message