From issues-return-95689-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Apr 25 10:10:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 237BF180638 for ; Thu, 25 Apr 2019 12:10:03 +0200 (CEST) Received: (qmail 2867 invoked by uid 500); 25 Apr 2019 10:10:02 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 2858 invoked by uid 99); 25 Apr 2019 10:10:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Apr 2019 10:10:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A5910E28DB for ; Thu, 25 Apr 2019 10:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3C9FA25812 for ; Thu, 25 Apr 2019 10:10:00 +0000 (UTC) Date: Thu, 25 Apr 2019 10:10:00 +0000 (UTC) From: "Amelchev Nikita (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-11671) Thin client: Client may hang when connected to a starting server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-11671?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 825935#comment-16825935 ]=20 Amelchev Nikita commented on IGNITE-11671: ------------------------------------------ I prepared a PR to fix this issue.=20 Connection id (long) consists of two 32-bits parts: 1. Node order (first part 32-bits) 2. Unique identifier (int) I removed node order and make unique identifier long type. Node order was used only for assertion on dropping a connection. Moreover, = this assertion fails after 2^31 attempts to connect.=20 If node order using to generate unique connection id per cluster and 2^31 i= s ok (24 days with 1ms attempt to connect), I will rework fix to wait for l= ocal node initialized. Another way is to revisit the generation of connecti= on id (For example, extend it to uuid). [~amashenkov], I see that you author of this feature. Could you take a look= , please?=20 > Thin client: Client may hang when connected to a starting server > ---------------------------------------------------------------- > > Key: IGNITE-11671 > URL: https://issues.apache.org/jira/browse/IGNITE-11671 > Project: Ignite > Issue Type: Bug > Components: thin client > Reporter: Aleksey Plekhanov > Assignee: Amelchev Nikita > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > If the server start process has not completed yet, but NIO listeners alre= ady started, the client may never get a response for the handshake request. > Exception on the server-side: > =C2=A0 > {noformat} > [client-connector-#6416%f3b837aa-d726-46b0-a58b-8cc6267c9f96%][ClientList= enerProcessor] Runtime error caught during grid runnable execution: GridWor= ker [name=3Dmessage-received-notify, igniteInstanceName=3Df3b837aa-d726-46b= 0-a58b-8cc6267c9f96, finished=3Dfalse, heartbeatTs=3D1554209548706, hashCod= e=3D519781823, interrupted=3Dfalse, runner=3Dclient-connector-#6416%f3b837a= a-d726-46b0-a58b-8cc6267c9f96%] > java.lang.NullPointerException > at org.apache.ignite.internal.processors.odbc.ClientListenerNioListener.n= extConnectionId(ClientListenerNioListener.java:334) > at org.apache.ignite.internal.processors.odbc.ClientListenerNioListener.p= repareContext(ClientListenerNioListener.java:313) > at org.apache.ignite.internal.processors.odbc.ClientListenerNioListener.o= nHandshake(ClientListenerNioListener.java:251) > at org.apache.ignite.internal.processors.odbc.ClientListenerNioListener.o= nMessage(ClientListenerNioListener.java:132) > at org.apache.ignite.internal.processors.odbc.ClientListenerNioListener.o= nMessage(ClientListenerNioListener.java:48) > at org.apache.ignite.internal.util.nio.GridNioFilterChain$TailFilter.onMe= ssageReceived(GridNioFilterChain.java:279) > at org.apache.ignite.internal.util.nio.GridNioFilterAdapter.proceedMessag= eReceived(GridNioFilterAdapter.java:109) > at org.apache.ignite.internal.util.nio.GridNioAsyncNotifyFilter$3.body(Gr= idNioAsyncNotifyFilter.java:97) > at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:= 120) > at org.apache.ignite.internal.util.worker.GridWorkerPool$1.run(GridWorker= Pool.java:70){noformat} > =C2=A0 > This happens because NIO listeners start=C2=A0before {{GridDiscoveryManag= er}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)