From issues-return-92560-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Sun Mar 3 22:50:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 79491180630 for ; Sun, 3 Mar 2019 23:50:04 +0100 (CET) Received: (qmail 37386 invoked by uid 500); 3 Mar 2019 22:50:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 37374 invoked by uid 99); 3 Mar 2019 22:50:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Mar 2019 22:50:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1FD1AC2113 for ; Sun, 3 Mar 2019 22:50:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Dz-XcBUEQ-m0 for ; Sun, 3 Mar 2019 22:50:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 53F015F35B for ; Sun, 3 Mar 2019 22:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5B38AE01AC for ; Sun, 3 Mar 2019 22:50:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 10A3125708 for ; Sun, 3 Mar 2019 22:50:00 +0000 (UTC) Date: Sun, 3 Mar 2019 22:50:00 +0000 (UTC) From: "Ivan Rakov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-11465) Multiple client leave/join events may wipe affinity assignment history and cause transactions fail MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782892#comment-16782892 ] Ivan Rakov commented on IGNITE-11465: ------------------------------------- TC: https://ci.ignite.apache.org/viewQueued.html?itemId=3227383 > Multiple client leave/join events may wipe affinity assignment history and cause transactions fail > -------------------------------------------------------------------------------------------------- > > Key: IGNITE-11465 > URL: https://issues.apache.org/jira/browse/IGNITE-11465 > Project: Ignite > Issue Type: Bug > Reporter: Ivan Rakov > Assignee: Ivan Rakov > Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > We keep history of GridAffinityAssignmentCache#MAX_HIST_SIZE affinity assignments. However, flood of client joins/leaves may wipe it out entirely and cause fail/hang of transaction that was started before the flood due to the following exception: > {code:java} > if (cache == null || cache.topologyVersion().compareTo(topVer) > 0) { > throw new IllegalStateException("Getting affinity for topology version earlier than affinity is " + > "calculated [locNode=" + ctx.discovery().localNode() + > ", grp=" + cacheOrGrpName + > ", topVer=" + topVer + > ", head=" + head.get().topologyVersion() + > ", history=" + affCache.keySet() + > ']'); > } > {code} > History is limited in order to prevent JVM heap overflow. At the same time, only "server event" affinity assignments are heavy: "client event" assignments are just shallow copies of "server event" assignments. > I suggest to limit history by the number of "server event" assignments. > Also, considering the provided fix, I don't see any need to keep 500 items in history. I propose to change history size to 50. -- This message was sent by Atlassian JIRA (v7.6.3#76005)