From issues-return-94085-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Mar 25 09:17:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5450F18075F for ; Mon, 25 Mar 2019 10:17:02 +0100 (CET) Received: (qmail 77044 invoked by uid 500); 25 Mar 2019 09:17:01 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 76744 invoked by uid 99); 25 Mar 2019 09:17:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Mar 2019 09:17:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BA523E2799 for ; Mon, 25 Mar 2019 09:17:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4B9692459C for ; Mon, 25 Mar 2019 09:17:00 +0000 (UTC) Date: Mon, 25 Mar 2019 09:17:00 +0000 (UTC) From: "Ignite TC Bot (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-11277) Use maven plugin as default code style checker for project MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800504#comment-16800504 ] Ignite TC Bot commented on IGNITE-11277: ---------------------------------------- {panel:title=--> Run :: All: No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=3383149&buildTypeId=IgniteTests24Java8_RunAll] > Use maven plugin as default code style checker for project > ---------------------------------------------------------- > > Key: IGNITE-11277 > URL: https://issues.apache.org/jira/browse/IGNITE-11277 > Project: Ignite > Issue Type: Task > Reporter: Maxim Muzafarov > Assignee: Maxim Muzafarov > Priority: Major > Labels: inspections > Fix For: 2.8 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Currently, {{[Inspections] Core suite}} [1] on TC doesn't work well enough. The suite has a {{FAILED}} status for more than 2 months due to some issues on TeamCity application [2]. It confuses most of the members of the Apache Ignite community. > Moreover, this suite is no longer checks configured rules. For instance, in the master branch, 11 {{Unused imports}} can be found (e.g. for {{IgniteCachePutAllRestartTest} > [3]). > I think the maven-checkstyle-plugin should be used as the default code style checker. > _Advantages:_ > * An IDE agnostic way for code checks > * Can be used with different CI and build tools > * Executable from the command line > * Single configuration > [1] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > [2] https://youtrack.jetbrains.com/issue/TW-58504 > [3] https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java#L29 -- This message was sent by Atlassian JIRA (v7.6.3#76005)