From issues-return-91612-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Feb 15 10:42:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1252F180651 for ; Fri, 15 Feb 2019 11:42:03 +0100 (CET) Received: (qmail 39858 invoked by uid 500); 15 Feb 2019 10:42:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 39849 invoked by uid 99); 15 Feb 2019 10:42:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Feb 2019 10:42:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CBDA1CD38B for ; Fri, 15 Feb 2019 10:42:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rVHychbZVMa5 for ; Fri, 15 Feb 2019 10:42:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2186760FBB for ; Fri, 15 Feb 2019 10:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C042DE261D for ; Fri, 15 Feb 2019 10:42:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 14F15244D8 for ; Fri, 15 Feb 2019 10:42:00 +0000 (UTC) Date: Fri, 15 Feb 2019 10:42:00 +0000 (UTC) From: "Andrew Mashenkov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-11330) Partition demander should skip entries for invalid partition. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-11330?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 769181#comment-16769181 ]=20 Andrew Mashenkov commented on IGNITE-11330: ------------------------------------------- Also, I've found we update metrics of all caches in group instead of the on= e that entry belongs to. Updating metrics of certain cache will broke CacheGroupsMetricsRebalanceTes= t.testRebalance(). Why we go this way? Is the test correct? > Partition demander should skip entries for invalid partition. > ------------------------------------------------------------- > > Key: IGNITE-11330 > URL: https://issues.apache.org/jira/browse/IGNITE-11330 > Project: Ignite > Issue Type: Bug > Components: cache > Reporter: Andrew Mashenkov > Priority: Major > Labels: performance, rebalance > Fix For: 2.8 > > > For now Partition demander tries to process all entries for invalid parti= tion instead of switching to the next partition. > Looks like, this was introduced with a fix IGNITE-8955 to make checkpoint= locks fine-grained. > A "for" loop under checkpoint readlock in GridDhtPartitionDemander.handle= SupplyMessage() causes the issue. A flow can=C2=A0breaks inner "for" loop i= n case of invalid partition, but seems an outer "while" loop expected. > =C2=A0 > To resolve this we can e.g. move=C2=A0CacheEntryInfo collection processin= g into separate method and just exit from it if invalid partition is detect= ed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)