From issues-return-90864-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Feb 12 08:44:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EB6D218062A for ; Tue, 12 Feb 2019 09:44:05 +0100 (CET) Received: (qmail 3868 invoked by uid 500); 12 Feb 2019 08:44:05 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 3858 invoked by uid 99); 12 Feb 2019 08:44:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2019 08:44:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8BCC1C2228 for ; Tue, 12 Feb 2019 08:44:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id NWtJMYpishjy for ; Tue, 12 Feb 2019 08:44:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F12B16247D for ; Tue, 12 Feb 2019 08:44:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D9FE1E2785 for ; Tue, 12 Feb 2019 08:44:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 62A6724487 for ; Tue, 12 Feb 2019 08:44:00 +0000 (UTC) Date: Tue, 12 Feb 2019 08:44:00 +0000 (UTC) From: "Vyacheslav Koptilin (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-11253) When a node that is not part of the baseline topology joins the cluster, it may lead to a node failure. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-11253?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 765807#comment-16765807 ]=20 Vyacheslav Koptilin commented on IGNITE-11253: ---------------------------------------------- Hi [~agura] , >=C2=A0Could you please add at least=C2=A0{{InterruptedException}}=C2=A0to= =C2=A0{{X.hasCause}}=C2=A0method's parameters.=C2=A0 Done! > When a node that is not part of the baseline topology joins the cluster, = it may lead to a node failure. > -------------------------------------------------------------------------= ------------------------------ > > Key: IGNITE-11253 > URL: https://issues.apache.org/jira/browse/IGNITE-11253 > Project: Ignite > Issue Type: Bug > Affects Versions: 2.7 > Reporter: Vyacheslav Koptilin > Assignee: Vyacheslav Koptilin > Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > * In case of eager TTL is configured, a starting node creates and starts = {{cleanupWorker}} (see {{GridCacheTtlManager.start0()}}) > * {{GridCacheSharedTtlCleanupManager.CleanupWorker}}, in its turn, has t= o wait for=C2=A0{{discovery().localJoin()}} future that is completed by dis= covery thread. > * On the other hand, the exchange thread stops cache contexts and, there= fore, it stops the {{cleanupWorker}} as well. > =C2=A0 > {code:java} > org.apache.ignite.internal.processors.cache.GridCacheSharedTtlCleanupMana= ger.stopCleanupWorker(GridCacheSharedTtlCleanupManager.java:109) > org.apache.ignite.internal.processors.cache.GridCacheSharedTtlCleanupMana= ger.unregister(GridCacheSharedTtlCleanupManager.java:82) > org.apache.ignite.internal.processors.cache.GridCacheTtlManager.onKernalS= top0(GridCacheTtlManager.java:110) > org.apache.ignite.internal.processors.cache.GridCacheManagerAdapter.onKer= nalStop(GridCacheManagerAdapter.java:111) > org.apache.ignite.internal.processors.cache.GridCacheProcessor.onKernalSt= op(GridCacheProcessor.java:1495) > org.apache.ignite.internal.processors.cache.GridCacheProcessor.onKernalSt= opCaches(GridCacheProcessor.java:1182) > org.apache.ignite.internal.processors.cache.GridCacheProcessor$CacheRecov= eryLifecycle.onBaselineChange(GridCacheProcessor.java:5637) > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.Gri= dDhtPartitionsExchangeFuture.initCachesOnLocalJoin(GridDhtPartitionsExchang= eFuture.java:910) > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.Gri= dDhtPartitionsExchangeFuture.init(GridDhtPartitionsExchangeFuture.java:792) > {code} > So, exchange thread may try to stop the {{cleanupWorker}} before the {{lo= calJoin}} future is completed by discovery thread. Unfortunately, `cleanupW= orker` incorrectly handles this situation, and this fact can lead to a node= failure: > {code:java} > Critical system error detected. Will be handled accordingly to configured= handler [hnd=3DStopNodeFailureHandler [super=3DAbstractFailureHandler [ign= oredFailureTypes=3DUnmodifiableSet [SYSTEM_WORKER_BLOCKED, SYSTEM_CRITICAL_= OPERATION_TIMEOUT]]], failureCtx=3DFailureContext [type=3DSYSTEM_WORKER_TER= MINATION, err=3Dclass o.a.i.IgniteException: Got interrupted while waiting = for future to complete.]] > class org.apache.ignite.IgniteException: Got interrupted while waiting fo= r future to complete. > at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager.loc= alJoin(GridDiscoveryManager.java:2217) > at org.apache.ignite.internal.processors.cache.GridCacheSharedTtlCleanupM= anager$CleanupWorker.body(GridCacheSharedTtlCleanupManager.java:136) > at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:= 120) > at java.lang.Thread.run(Thread.java:748) > Caused by: class org.apache.ignite.internal.IgniteInterruptedCheckedExcep= tion: Got interrupted while waiting for future to complete. > at org.apache.ignite.internal.util.future.GridFutureAdapter.get0(GridFutu= reAdapter.java:186) > at org.apache.ignite.internal.util.future.GridFutureAdapter.get(GridFutur= eAdapter.java:141) > at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager.loc= alJoin(GridDiscoveryManager.java:2214) > ... 3 more > {code} > =C2=A0The obvious fix is changing the catch block > {code:java} > catch (Throwable t) { > if (!(t instanceof IgniteInterruptedCheckedException)) > err =3D t; > throw t; > } > {code} > to the following: > {code:java} > catch (Throwable t) { > if (!(X.hasCause(t, IgniteInterruptedCheckedException.class))) > err =3D t; > throw t; > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)