From issues-return-90673-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Feb 8 12:49:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3BEF818067E for ; Fri, 8 Feb 2019 13:49:07 +0100 (CET) Received: (qmail 27209 invoked by uid 500); 8 Feb 2019 12:49:06 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 27035 invoked by uid 99); 8 Feb 2019 12:49:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Feb 2019 12:49:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9D083181A3E for ; Fri, 8 Feb 2019 12:49:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id EMYCf_ObVVpi for ; Fri, 8 Feb 2019 12:49:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BB2B46243B for ; Fri, 8 Feb 2019 12:49:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8DFC5E274B for ; Fri, 8 Feb 2019 12:49:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DAB1724460 for ; Fri, 8 Feb 2019 12:49:00 +0000 (UTC) Date: Fri, 8 Feb 2019 12:49:00 +0000 (UTC) From: "Pavel Voronkin (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Issue Comment Deleted] (IGNITE-7648) Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-7648?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Voronkin updated IGNITE-7648: ----------------------------------- Comment: was deleted (was: We changed behaviour of ENABLED_FORCIBLE_NODE_KILL=3Dtrue in this tic= ket. Only server node can kill client node in case if property is enabled. client can't kill server, server can't kill server. Timeout logic changed in case of failure detection enabled scenario We start connect and hanshake from timeout 500ms. If=C2=A0failed we increas= e timeout using exponential backoff strategy timeout=C2=A0=3D Math.min(Math.min(timeout * 2, maxTimeout), remainingTiime= TillFailureDetection) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0) > Fix IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. > ----------------------------------------------------- > > Key: IGNITE-7648 > URL: https://issues.apache.org/jira/browse/IGNITE-7648 > Project: Ignite > Issue Type: Improvement > Affects Versions: 2.3 > Reporter: Alexei Scherbakov > Assignee: Pavel Voronkin > Priority: Major > Fix For: 2.8 > > > IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in IGNITE= -5718 as a way to prevent=C2=A0unnecessary node drops in case of short netw= ork problems. > I suppose it's wrong decision to fix it in such way. > We had faced some issues in our production due to lack of automatic kicki= ng of ill-behaving nodes (on example, hanging due to long GC pauses) until = we realised the necessity of changing default behavior via property. > Right solution is to kick nodes only=C2=A0if failure threshold is reached= . Such behavior should be always enabled. > UPDATE: During a discussion it was decided what the property will remain = disabled by default. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)