ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Muzafarov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-11277) Use maven plugin as default code style checker for project
Date Mon, 18 Feb 2019 16:28:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771200#comment-16771200

Maxim Muzafarov commented on IGNITE-11277:

–°hanges that have been made:
 # Configured {{maven-checkstyle-plugin}} for all the Apache Ignite project
 # {{checkstyle}} profile configured and is active by default
 # These checkstyle rules are configured
 ** {{FileTabCharacter}} (an {{ProblematicWhitespace}} analogue inspection)
 ** {{UnusedImports}} (an {{UnusedImport}} analogue inspection)
 ** {{ModifierOrder}} (a {{MissortedModifiers}} analogue inspection)
 # These inspections rules don't have direct analogue or working not the same
 ** {{SizeReplaceableByIsEmpty}} doesn't have a direct analogue of checkstyle modules
 ** {{MissingOverrideAnnotation}} inspection has a [{{MissingOverride}}|http://checkstyle.sourceforge.net/config_annotation.html#MissingOverride]
analogue module for the checkstyle plugin. It is working not the same way. Must be implemented
in the separate ticket
 ** {{RedundantSuppression}} inspection doesn't have the direct analogue of checkstyle module
 # All additional files are fixed (e.g. unused imports removed) to make project compile.

> Use maven plugin as default code style checker for project
> ----------------------------------------------------------
>                 Key: IGNITE-11277
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11277
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Maxim Muzafarov
>            Assignee: Maxim Muzafarov
>            Priority: Major
>              Labels: inspections
>             Fix For: 2.8
>          Time Spent: 10m
>  Remaining Estimate: 0h
> Currently, {{[Inspections] Core suite}} [1] on TC doesn't work well enough. The suite
has a {{FAILED}} status for more than 2 months due to some issues on TeamCity application
[2]. It confuses most of the members of the Apache Ignite community. 
> Moreover, this suite is no longer checks configured rules. For instance, in the master
branch, 11 {{Unused imports}} can be found (e.g. for {{IgniteCachePutAllRestartTest} 
>  [3]).
> I think the maven-checkstyle-plugin should be used as the default code style checker.
> _Advantages:_
> * An IDE agnostic way for code checks
> * Can be used with different CI and build tools
> * Executable from the command line
> * Single configuration
> [1] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv
> [2] https://youtrack.jetbrains.com/issue/TW-58504
> [3] https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java#L29

This message was sent by Atlassian JIRA

View raw message