ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Chugunov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-10748) Remove dead code in TcpCommunicationSpi for the tcp client creation flow
Date Mon, 04 Feb 2019 12:59:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759835#comment-16759835
] 

Sergey Chugunov commented on IGNITE-10748:
------------------------------------------

[~Mmuzaf],

Proposed change looks good to me in general, I left some comments in the PR suggesting minor
changes and fixes.

> Remove dead code in TcpCommunicationSpi for the tcp client creation flow
> ------------------------------------------------------------------------
>
>                 Key: IGNITE-10748
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10748
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Maxim Muzafarov
>            Assignee: Maxim Muzafarov
>            Priority: Minor
>             Fix For: 2.8
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Currently, a batch of changes can be applied over {{TcpCommunicationSpi}} class implementation
due to:
> # {{safeTcpHandshake(..)}}
> #* {{handshakeConnIdx}} - parameter is always not null
> #* {{recovery}} - parameter is always not null
> #* {{HandhakeMessage}} - is not used in current flow at all
> # {{HandshakeMessage2}}
> #* Message size must be defined in the message class as constant
> # {{createTcpClient(..)}}
> #* Instantiation of {{GridTcpNioCommunicationClient}} must be performed outside the while-loop
> # Code-style issues. Fix one-liner if statements.
> # Extract internal {{HandshakeException}}, {{HandshakeTimeoutException}} from class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message