From issues-return-89770-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Jan 30 12:22:10 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 82DB5180652 for ; Wed, 30 Jan 2019 13:22:09 +0100 (CET) Received: (qmail 1124 invoked by uid 500); 30 Jan 2019 12:22:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 986 invoked by uid 99); 30 Jan 2019 12:22:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jan 2019 12:22:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1CD6AC0504 for ; Wed, 30 Jan 2019 12:22:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id uDFhSW0UjTkV for ; Wed, 30 Jan 2019 12:22:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F046D60FA4 for ; Wed, 30 Jan 2019 12:22:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7A7AAE0A31 for ; Wed, 30 Jan 2019 12:22:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1B954243B7 for ; Wed, 30 Jan 2019 12:22:00 +0000 (UTC) Date: Wed, 30 Jan 2019 12:22:00 +0000 (UTC) From: "Igor Seliverstov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-10976) MVCC: Sql API methods should throws proper TransactionExceptions in case of tx failure. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-10976?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 756034#comment-16756034 ]=20 Igor Seliverstov commented on IGNITE-10976: ------------------------------------------- [~amashenkov], see my comments below: 1) DmlStatementsProcessor#toSqlException since IgniteSQLException is a part= of ignite-core and SQLException is a part of java runtime it's OK to move = this method to IgniteUtils (where we do exception conversions) 2) DmlStatementsProcessor.java:660 seems it's already done in IgniteUtils.c= onvertException(..) let's use IgniteUtils instead 3) GridCacheDistributedQueryFuture.java:152 Is it OK we use ClusterTopology= Exception instead of ClusterTopologyCheckedException? I'm not sure we don't= break remap logic by this change. 4) GridCacheUtils.java:1318 I think it should be done by exception conversi= on that is being done below. 5) IgniteCacheMessageRecoveryIdleConnectionTest#beforeTestsStarted Destroyi= ng cache before a test looks quite tricky > MVCC: Sql API methods should throws proper TransactionExceptions in case = of tx failure. > -------------------------------------------------------------------------= -------------- > > Key: IGNITE-10976 > URL: https://issues.apache.org/jira/browse/IGNITE-10976 > Project: Ignite > Issue Type: Bug > Components: mvcc, sql > Reporter: Andrew Mashenkov > Assignee: Andrew Mashenkov > Priority: Major > Fix For: 2.8 > > Time Spent: 0.5h > Remaining Estimate: 0h > > For now Sql API can throws=C2=A0SqlException (without any actual Tx failu= re cause) or TransactionException wrapped into CacheException. > Also, I've found we convert unchecked exceptions into checked ones and th= en back without any obvious reason. > Let's make TransactionException thows properly and add it to Sql Api cont= ract. -- This message was sent by Atlassian JIRA (v7.6.3#76005)