ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Ignatenko (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (IGNITE-11116) replace Assert in particular test classes from junit.framework (JUnit 3) to org.junit (JUnit 4)
Date Tue, 29 Jan 2019 08:20:00 GMT

     [ https://issues.apache.org/jira/browse/IGNITE-11116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Ignatenko updated IGNITE-11116:
------------------------------------
    Ignite Flags:   (was: Docs Required)

> replace Assert in particular test classes from junit.framework (JUnit 3) to org.junit
(JUnit 4)
> -----------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-11116
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11116
>             Project: Ignite
>          Issue Type: Sub-task
>    Affects Versions: 2.7
>            Reporter: Oleg Ignatenko
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>
> Some tests start failing on Teamcity when Assert is replaced to one from {{org.junit}}
package (note I couldn't reliably reproduce these failures locally). Per my observations it
looks like troublesome code involves {{assertEquals}} that compares double / float values
with non-zero delta. This issue was discovered in the course of IGNITE-10927.
> Search in the [PR 5866|https://github.com/apache/ignite/pull/5866] linked to IGNITE-10927
for import of {{junit.framework.Assert}} shows that this involves ZookeeperDiscoverySpiTestHelper,
IoStatisticsMetricsLocalMXBeanImplSelfTest, BinaryMarshallerSelfTest, RestMemcacheProtocolSelfTest.
> Search in this PR for static import of {{junit.framework.Assert}} shows 12 more involved
test classes, CassandraConfigTest, ClientCacheFlagsCodecTest etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message