ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryabov Dmitrii (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo
Date Mon, 21 Jan 2019 09:05:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747764#comment-16747764
] 

Ryabov Dmitrii commented on IGNITE-10978:
-----------------------------------------

[~kbolyandra], [~dpavlov], hello,

I think we should uncomment tests instead of removing. As I see, we have some of these classes
in the codebase, so, I propose to uncomment existing tests and run [TeamCity|https://ci.ignite.apache.org/].

As for nonexisting tests - they could be renamed. Konstantin, please, find a commit where
they were removed or renamed?

> Remove unused tests marked with unclear todo
> --------------------------------------------
>
>                 Key: IGNITE-10978
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10978
>             Project: Ignite
>          Issue Type: Task
>    Affects Versions: 2.7
>            Reporter: Dmitriy Pavlov
>            Assignee: Konstantin Bolyandra
>            Priority: Major
>              Labels: newbie
>             Fix For: 2.8
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //        GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, ignoredTests);
> //        GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class,
ignoredTests);
> //        GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //        GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
ignoredTests);
> //        GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
ignoredTests);
> //        GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class,
ignoredTests);
> //        GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class,
ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message