ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Ozerov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-10629) Migration follow up: check for old style tests that could be slipped through in transition period
Date Wed, 23 Jan 2019 09:07:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749691#comment-16749691

Vladimir Ozerov commented on IGNITE-10629:

[~oignatenko], patch looks good to me.

> Migration follow up: check for old style tests that could be slipped through in transition
> -------------------------------------------------------------------------------------------------
>                 Key: IGNITE-10629
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10629
>             Project: Ignite
>          Issue Type: Sub-task
>    Affects Versions: 2.8
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>         Attachments: junit_inspections.xml
>          Time Spent: 10m
>  Remaining Estimate: 0h
> We need to account for risk that while tests are migrating some commits may by mistake
slip in old style test cases - that will be ignored by JUnit 4.
> In order to address possible issues of that kind, do the following a week or two after
IGNITE-10177 is merged to master: run the IntelliJ inspection called "old style Junit test
method in JUnit 4 class", review report and fix discovered problems if there are any.
> For the reference, my version of IDE explains this inspection as follows:
>  {quote}Reports JUnit 3 style test methods which are located inside a class which does
not extend the abstract JUnit 3 class TestCase and contains JUnit 4/JUnit 5 @Test annotated
>  (note concerns mentioned in this ticket were originally raised at dev list: [here|http://apache-ignite-developers.2346864.n4.nabble.com/Is-it-time-to-move-forward-to-JUnit4-5-tp29608p39300.html])
> -----
> Another part of this task is to find (and rework if there are still any) classes that
still extend {{junit.framework.TestCase}}. These classes are technically legal but after vast
majority have been migrated they became harmful from maintenance perspective, by forcing readers
of their code learn details of obsolete framework version that lacks many important features.
One particularly bad thing about such tests is that they deprive maintainers standard ways
to suppress test execution using modern JUnit API of Ignore and Assume.

This message was sent by Atlassian JIRA

View raw message