ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Ignatenko (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-10629) Migration follow up: check for old style tests that could be slipped through in transition period
Date Wed, 16 Jan 2019 15:38:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715885#comment-16715885
] 

Oleg Ignatenko edited comment on IGNITE-10629 at 1/16/19 3:37 PM:
------------------------------------------------------------------

(i) draft inspections profile attached: [^junit_inspections.xml]

(i) appropriate cut-off date appears to be 22/Dec/18 when IGNITE-10177 was marked resolved
(merged to master). After changes made to master per this ticket it became impossible to have
working test inheriting [GridAbstractTest|https://github.com/apache/ignite/commits/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java]
other than using JUnit 4 (JUnit 3 kind tests wouldn't execute and IDEA would highlight respective
test cases with warnings about unused methods)


was (Author: oignatenko):
(i) draft inspections profile attached: [^junit_inspections.xml]

> Migration follow up: check for old style tests that could be slipped through in transition
period
> -------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-10629
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10629
>             Project: Ignite
>          Issue Type: Sub-task
>    Affects Versions: 2.8
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>         Attachments: junit_inspections.xml
>
>
> We need to account for risk that while tests are migrating some commits may by mistake
slip in old style test cases - that will be ignored by JUnit 4.
> In order to address possible issues of that kind, do the following a week or two after
IGNITE-10177 is merged to master: run the IntelliJ inspection called "old style Junit test
method in JUnit 4 class", review report and fix discovered problems if there are any.
> For the reference, my version of IDE explains this inspection as follows:
>  {quote}Reports JUnit 3 style test methods which are located inside a class which does
not extend the abstract JUnit 3 class TestCase and contains JUnit 4/JUnit 5 @Test annotated
methods.{quote}
>  (note concerns mentioned in this ticket were originally raised at dev list: [here|http://apache-ignite-developers.2346864.n4.nabble.com/Is-it-time-to-move-forward-to-JUnit4-5-tp29608p39300.html])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message