ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Ignatenko (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-10178) change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
Date Fri, 25 Jan 2019 18:16:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752458#comment-16752458

Oleg Ignatenko edited comment on IGNITE-10178 at 1/25/19 6:15 PM:

(/) [~Mmuzaf] coding guidelines were updated as you recommended in comment above, thanks for

was (Author: oignatenko):
(/) [~Mmuzaf] coding guidelines were edited as you recommended in [comment above|https://issues.apache.org/jira/browse/IGNITE-10178?focusedCommentId=16716635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16716635],
thanks for suggestion!

> change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
> -------------------------------------------------------------------------------------
>                 Key: IGNITE-10178
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10178
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>             Fix For: 2.8
>          Time Spent: 20m
>  Remaining Estimate: 0h
> Change tests that use {{fail("Ignite JIRA ticket URL")}} to {{@Ignore("Ignite JIRA ticket
URL")}}. Do the same change for tests that fail by {{@IgniteIgnore("Ignite JIRA ticket URL")}},
like for example [S3CheckpointSpiStartStopSelfTest.testStartStop|https://github.com/apache/ignite/blob/master/modules/aws/src/test/java/org/apache/ignite/spi/checkpoint/s3/S3CheckpointSpiStartStopSelfTest.java].
Also, use [Ignore|http://junit.sourceforge.net/javadoc/org/junit/Ignore.html] to annotate
empty test classes in examples that were discovered and re-muted per IGNITE-10174.
> If needed, refer parent task for more details.
> Note this step would better be coordinated with Teamcity and TC bot maintainers because
it may substantially impact them.
> -----
> Note that tests that are expected to be ignored depending on runtime conditions should
be rewritten to use {{Assume}} instead of {{fail}}. So that old code...
> {code}if (someRuntimeCondition())
>     fail("Ignite JIRA ticket URL");{code}
> ...will change to
> {code}Assume.assumeFalse("Ignite JIRA ticket URL", someRuntimeCondition());{code}
> (this change can be "extracted" into separate JIRA task if it is more convenient). Readers
interested to find more details about how {{Assume}} works can find more details and code
snippet [in comments here|https://issues.apache.org/jira/browse/IGNITE-10178?focusedCommentId=16723863&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16723863].

This message was sent by Atlassian JIRA

View raw message