From issues-return-85724-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Dec 14 10:04:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2246A180679 for ; Fri, 14 Dec 2018 10:04:03 +0100 (CET) Received: (qmail 31097 invoked by uid 500); 14 Dec 2018 09:04:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 30972 invoked by uid 99); 14 Dec 2018 09:04:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Dec 2018 09:04:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7C30B1809E0 for ; Fri, 14 Dec 2018 09:04:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id R7bXDJ3iTrlh for ; Fri, 14 Dec 2018 09:04:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2002A5F117 for ; Fri, 14 Dec 2018 09:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9EAE0E02F1 for ; Fri, 14 Dec 2018 09:04:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 185E523FA7 for ; Fri, 14 Dec 2018 09:04:00 +0000 (UTC) Date: Fri, 14 Dec 2018 09:04:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-10680) Add the ability to use existing kernel context in standalone WAL iterator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-10680?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 721078#comment-16721078 ]=20 ASF GitHub Bot commented on IGNITE-10680: ----------------------------------------- GitHub user alex-plekhanov opened a pull request: https://github.com/apache/ignite/pull/5669 IGNITE-10680 Add the ability to use existing kernel context in standalo= ne WAL iterator =20 You can merge this pull request into a Git repository by running: $ git pull https://github.com/alex-plekhanov/ignite ignite-10680 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5669.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5669 =20 ---- commit 659cd31cce85aebdc097c20f807d5b1cd4ef476b Author: Aleksey Plekhanov Date: 2018-12-14T09:01:19Z IGNITE-10680 Add the ability to use existing kernel context in standalo= ne WAL iterator ---- > Add the ability to use existing kernel context in standalone WAL iterator > ------------------------------------------------------------------------- > > Key: IGNITE-10680 > URL: https://issues.apache.org/jira/browse/IGNITE-10680 > Project: Ignite > Issue Type: Improvement > Affects Versions: 2.7 > Reporter: Aleksey Plekhanov > Assignee: Aleksey Plekhanov > Priority: Major > Fix For: 2.8 > > > In the current implementation it's only possible to use fake kernel=C2=A0= context in standalone WAL iterator. If we need to use binary meta from the = running Ignite node we must specify binary meta directory in parameters of = standalone WAL iterator factory. But there is a possible race with binary m= eta files read/write since binary meta received with {{MetadataUpdatePropos= edMessage}} can be written to the file and concurrently read from the same = file at the same time. This can lead to assertions like the following: > {noformat} > java.lang.AssertionError > =09at org.apache.ignite.internal.binary.GridBinaryMarshaller.deserialize(= GridBinaryMarshaller.java:305) > =09at org.apache.ignite.internal.binary.BinaryMarshaller.unmarshal0(Binar= yMarshaller.java:121) > =09at org.apache.ignite.marshaller.AbstractNodeNameAwareMarshaller.unmars= hal(AbstractNodeNameAwareMarshaller.java:94) > =09at org.apache.ignite.internal.util.IgniteUtils.unmarshal(IgniteUtils.j= ava:10103) > =09at org.apache.ignite.internal.processors.cache.binary.BinaryMetadataFi= leStore.restoreMetadata(BinaryMetadataFileStore.java:117) > =09at org.apache.ignite.internal.processors.cache.binary.CacheObjectBinar= yProcessorImpl.start(CacheObjectBinaryProcessorImpl.java:251) > =09at org.apache.ignite.internal.processors.cache.persistence.wal.reader.= StandaloneGridKernalContext.binaryProcessor(StandaloneGridKernalContext.jav= a:180) > =09at org.apache.ignite.internal.processors.cache.persistence.wal.reader.= StandaloneGridKernalContext.(StandaloneGridKernalContext.java:155) > =09at org.apache.ignite.internal.processors.cache.persistence.wal.reader.= IgniteWalIteratorFactory.prepareSharedCtx(IgniteWalIteratorFactory.java:359= ) > =09at org.apache.ignite.internal.processors.cache.persistence.wal.reader.= IgniteWalIteratorFactory.iterator(IgniteWalIteratorFactory.java:177) > {noformat} > To solve this we can use in standalone WAL iterator existing kernel conte= xt of the started node instead of creating new fake one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)