From issues-return-85352-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Dec 11 17:08:47 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 36377180671 for ; Tue, 11 Dec 2018 17:08:47 +0100 (CET) Received: (qmail 17465 invoked by uid 500); 11 Dec 2018 16:08:46 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 17456 invoked by uid 99); 11 Dec 2018 16:08:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Dec 2018 16:08:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D5DC6180C9B for ; Tue, 11 Dec 2018 16:08:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id fNheSwqu48j0 for ; Tue, 11 Dec 2018 16:08:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1DE7D61064 for ; Tue, 11 Dec 2018 16:02:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A948FE111B for ; Tue, 11 Dec 2018 16:02:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 53AF4252F6 for ; Tue, 11 Dec 2018 16:02:00 +0000 (UTC) Date: Tue, 11 Dec 2018 16:02:00 +0000 (UTC) From: "Pavel Kuznetsov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-10645) SQL properties ownership flag should be set at configuration parsing, not query execution. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717438#comment-16717438 ] Pavel Kuznetsov commented on IGNITE-10645: ------------------------------------------ Now there are some thests that have configuration: {noformat} LinkedHashMap fields = new LinkedHashMap<>(); fields.put("keyStr", String.class.getName()); fields.put("keyLong", Long.class.getName()); fields.put("keyPojo", Pojo.class.getName()); fields.put("valStr", String.class.getName()); fields.put("valLong", Long.class.getName()); fields.put("valPojo", Pojo.class.getName()); ent = new QueryEntiry (Key.class.getName(), Value.class.getName()) .setFields(fields) {noformat} It's expected that engine somehow understands that field "keyStr" belongs to a key, which is wrong. Updating such tests. > SQL properties ownership flag should be set at configuration parsing, not query execution. > ------------------------------------------------------------------------------------------ > > Key: IGNITE-10645 > URL: https://issues.apache.org/jira/browse/IGNITE-10645 > Project: Ignite > Issue Type: Bug > Components: sql > Reporter: Pavel Kuznetsov > Assignee: Pavel Kuznetsov > Priority: Major > > At processing time, query entities are transformed and validated, table descriptors with properties are created. > Now in some case (thre's no keyFields and key is of complex non-sql type), ownership flag of query property is calculated at execution time (for example at first put()): > https://github.com/apache/ignite/blob/dcdb27a24a450f63487290360b265e1570534629/modules/core/src/main/java/org/apache/ignite/internal/processors/query/property/QueryBinaryProperty.java#L132 > So we can't access metadata, that uses this not-yet-initialized field before we put the data. > But we already have all necessary info to set this field at processing time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)