From issues-return-85115-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Dec 10 17:49:15 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 00CAA180648 for ; Mon, 10 Dec 2018 17:49:14 +0100 (CET) Received: (qmail 90586 invoked by uid 500); 10 Dec 2018 16:49:14 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 90577 invoked by uid 99); 10 Dec 2018 16:49:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Dec 2018 16:49:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9E973C0656 for ; Mon, 10 Dec 2018 16:49:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 6uA7JvrqQ6bV for ; Mon, 10 Dec 2018 16:49:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B788D60CFD for ; Mon, 10 Dec 2018 16:41:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DC265E261D for ; Mon, 10 Dec 2018 16:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 56E04252F3 for ; Mon, 10 Dec 2018 16:41:00 +0000 (UTC) Date: Mon, 10 Dec 2018 16:41:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-9542) [TC bot] provide separated base/current branch history for PR page MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715049#comment-16715049 ] ASF GitHub Bot commented on IGNITE-9542: ---------------------------------------- dspavlov commented on a change in pull request #95: IGNITE-9542: new run history stripe URL: https://github.com/apache/ignite-teamcity-bot/pull/95#discussion_r240287246 ########## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/issue/IssueDetector.java ########## @@ -446,9 +463,9 @@ protected String checkFailuresEx(String brachName) { backgroundOpsCreds ); - registerIssuesAndNotifyLater(failures, backgroundOpsCreds); + String issResult = registerIssuesAndNotifyLater(failures, backgroundOpsCreds); Review comment: Yes, I agree, but this string will go to the monitoring, so it is better to see null showing there is some unexpected behavior there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > [TC bot] provide separated base/current branch history for PR page > ------------------------------------------------------------------ > > Key: IGNITE-9542 > URL: https://issues.apache.org/jira/browse/IGNITE-9542 > Project: Ignite > Issue Type: Bug > Reporter: Dmitriy Pavlov > Assignee: Dmitriy Pavlov > Priority: Major > > https://issues.apache.org/jira/browse/IGNITE-9376 > works incorrectly without separation of test history for the base and for a shown branch. > It is suggested to refactor provided data for the current and for the base branch. > It will allow showing blockers based on statistics from any base branch without relation with the previous quering of data. -- This message was sent by Atlassian JIRA (v7.6.3#76005)