From issues-return-85883-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Dec 14 21:19:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3D239180645 for ; Fri, 14 Dec 2018 21:19:04 +0100 (CET) Received: (qmail 75267 invoked by uid 500); 14 Dec 2018 20:19:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 75258 invoked by uid 99); 14 Dec 2018 20:19:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Dec 2018 20:19:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 052BE1809E6 for ; Fri, 14 Dec 2018 20:19:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3V1I1mPXSMzv for ; Fri, 14 Dec 2018 20:19:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 579095F19A for ; Fri, 14 Dec 2018 20:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AB50DE00D4 for ; Fri, 14 Dec 2018 20:19:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 49CCC23FAE for ; Fri, 14 Dec 2018 20:19:00 +0000 (UTC) Date: Fri, 14 Dec 2018 20:19:00 +0000 (UTC) From: "Denis Magda (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (IGNITE-8411) Binary Client Protocol spec: other parts clarifications MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-8411?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis Magda updated IGNITE-8411: -------------------------------- Fix Version/s: (was: 2.7) 2.8 > Binary Client Protocol spec: other parts clarifications > ------------------------------------------------------- > > Key: IGNITE-8411 > URL: https://issues.apache.org/jira/browse/IGNITE-8411 > Project: Ignite > Issue Type: Improvement > Components: documentation, thin client > Affects Versions: 2.4 > Reporter: Alexey Kosenchuk > Priority: Major > Fix For: 2.8 > > > issues against previous parts: IGNITE-8039 IGNITE-8212 > Cache Configuration > ------------------- > [https://apacheignite.readme.io/docs/binary-client-protocol-cache-config= uration-operations] > - OP_CACHE_GET_CONFIGURATION and OP_CACHE_CREATE_WITH_CONFIGURATION - Qu= eryEntity - Structure of QueryField: > absent "default value - type Object" - it is the last field of the Query= Field in reality. > - OP_CACHE_GET_CONFIGURATION - Structure of Cache Configuration: > Absent CacheAtomicityMode - is the first field in reality. > Absent MaxConcurrentAsyncOperations - is between DefaultLockTimeout and = MaxQueryIterators in reality. > "Invalidate" field - does not exist in reality. > - meaning and possible values of every configuration parameter must be c= larified. If clarified in other docs, this spec must have link(s) to that d= ocs. > - suggest to combine somehow Cache Configuration descriptions in OP_CACH= E_GET_CONFIGURATION and OP_CACHE_CREATE_WITH_CONFIGURATION - to avoid dupli= cated descriptions. > SQL and Scan Queries > -------------------- > [https://apacheignite.readme.io/docs/binary-client-protocol-sql-operatio= ns] > - "Flag. Pass 0 for default, or 1 to keep the value in binary form.": > "the value in binary form" flag should be left end clarified in the oper= ations to which it is applicable for. > - OP_QUERY_SQL: > most of the fields in the request must be clarified. If clarified in oth= er docs, this spec must have link(s) to that docs. > For example: > ** "Name of a type or SQL table": name of what type? > - OP_QUERY_SQL_FIELDS: > most of the fields in the request must be clarified. If clarified in oth= er docs, this spec must have link(s) to that docs. > For example: > ** is there any correlation between "Query cursor page size" and "Max ro= ws"? > ** "Statement type": why there are only three types? what about INSERT, = etc.? > - OP_QUERY_SQL_FIELDS_CURSOR_GET_PAGE Response does not contain Cursor i= d. But responses for all other query operations contain it. Is it intention= al? > - OP_QUERY_SCAN_CURSOR_GET_PAGE Response - Cursor id is absent in realit= y. > - OP_QUERY_SCAN_CURSOR_GET_PAGE Response - Row count field: says type "l= ong". Should be "int". > - OP_QUERY_SCAN: > format and rules of the Filter object must be clarified. If clarified in= other docs, this spec must have link(s) to that docs. > - OP_QUERY_SCAN: > in general, it's not clear how this operation should be supported on pla= tforms other than the mentioned in "Filter platform" field. > - OP_QUERY_SCAN: "Number of partitions to query" > Should be updated to "A partition number to query" > =C2=A0 > Binary Types > ------------ > [https://apacheignite.readme.io/docs/binary-client-protocol-binary-type-= operations] > - somewhere should be explained when and why these operations need to be= supported by a client. > - Type id and Field id: > should be clarified that before an Id calculation Type and Field names m= ust be updated to low case. > - OP_GET_BINARY_TYPE and OP_PUT_BINARY_TYPE - BinaryField - Type id: > in reality it is not a type id (hash code) but a type code (1, 2,... 10,= ... 103,...). > - OP_GET_BINARY_TYPE and OP_PUT_BINARY_TYPE - "Affinity key field name": > should be explained what is it. If explained in other docs, this spec mu= st have link(s) to that docs. > - OP_PUT_BINARY_TYPE - schema id: > mandatory algorithm of schema Id calculation must be described somewhere= . If described in other docs, this spec must have link(s) to that docs. > - OP_REGISTER_BINARY_TYPE_NAME and OP_GET_BINARY_TYPE_NAME: > should be explained when and why these operations need to be supported b= y a client. > How this operation should be supported on platforms other than the menti= oned in "Platform id" field. > - OP_REGISTER_BINARY_TYPE_NAME: > Type name - is it "full" or "short" name here? > Type id - is it a hash from "full" or "short" name here? -- This message was sent by Atlassian JIRA (v7.6.3#76005)