ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Ignatenko (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (IGNITE-10758) remove from tests scaffolding annotations "@RunWith(JUnit4.class)" and their respective imports
Date Thu, 20 Dec 2018 14:36:00 GMT

     [ https://issues.apache.org/jira/browse/IGNITE-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Oleg Ignatenko updated IGNITE-10758:
    Labels: MakeTeamcityGreenAgain  (was: )

> remove from tests scaffolding annotations "@RunWith(JUnit4.class)" and their respective
> -----------------------------------------------------------------------------------------------
>                 Key: IGNITE-10758
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10758
>             Project: Ignite
>          Issue Type: Sub-task
>    Affects Versions: 2.8
>            Reporter: Oleg Ignatenko
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
> In the course of IGNITE-10175 and IGNITE-10176 many test classes were annotated {{@RunWith(JUnit4.class)}}.
This was necessary to allow gradual switching to JUnit 4 to let classes run under the version
that worked for these.
> After IGNITE-10177 is over, these scaffolding annotations will be not needed anymore
(and will become even somewhat damaging by misleading readers to think that they serve some
real purpose).
> The task is to remove these annotations and respective import statements after IGNITE-10177
is merged to master. Note it was initially planned as a part of IGNITE-10177 but per discussion
with [~EdShangGG] we decided that it will be more convenient to do this in a separate ticket
because this will make changes much easier to review, test and merge.
> (!) Thing worth paying attention is that mentioned annotations should be kept in one
case - namely in root test class {{GridAbstractTest}} because over there these are necessary
until JUnit 3 dependencies are wiped out from remaining cases listed in IGNITE-10739.

This message was sent by Atlassian JIRA

View raw message