ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-10645) SQL properties ownership flag should be set at configuration parsing, not query execution.
Date Wed, 12 Dec 2018 20:34:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719411#comment-16719411

ASF GitHub Bot commented on IGNITE-10645:

GitHub user pavel-kuznetsov opened a pull request:


    IGNITE-10645: QueryBinaryProperty's isKey logic


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-10645

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5657
commit 42bb29bf24ab221c4a16655cce4c098bc65535b1
Author: Pavel Kuznetsov <palmihal@...>
Date:   2018-12-12T20:27:51Z

    ignite-10645: Removed runtime property configuration.
    Previously, in some cases (key is not of sql type and keyFields is null)
     QueryBinaryProperty was configured at runtime (at first cache.put()).
    Removed this logic, so now properties are configured when all binary
    metadata gets processed.

commit 4aaaea81caa1d81ccd73b8e7b1d43ca34377b791
Author: Pavel Kuznetsov <palmihal@...>
Date:   2018-12-12T20:30:55Z

    ignite-10645: Updated incorrect tests.
    These tests used non-sql KeyObject, and expected that keyFields get
    filled somehow (what is not supported). Added explicit keyFilds


> SQL properties ownership flag should be set at configuration parsing, not query execution.
> ------------------------------------------------------------------------------------------
>                 Key: IGNITE-10645
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10645
>             Project: Ignite
>          Issue Type: Bug
>          Components: sql
>            Reporter: Pavel Kuznetsov
>            Assignee: Pavel Kuznetsov
>            Priority: Major
> At processing time, query entities are transformed and validated, table descriptors with
properties are created.
> Now in some case (thre's no keyFields and key is of complex non-sql type), ownership
flag of query property is calculated at execution time (for example at first put()): 
> https://github.com/apache/ignite/blob/dcdb27a24a450f63487290360b265e1570534629/modules/core/src/main/java/org/apache/ignite/internal/processors/query/property/QueryBinaryProperty.java#L132
> So we can't access metadata, that uses this not-yet-initialized field before we put the
> But we already have all necessary info to set this field at processing time.

This message was sent by Atlassian JIRA

View raw message