ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Ignatenko (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (IGNITE-10450) In Ignite code style inspections increase level for those used at Teamcity build checks
Date Wed, 12 Dec 2018 08:56:00 GMT

     [ https://issues.apache.org/jira/browse/IGNITE-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Ignatenko reassigned IGNITE-10450:
---------------------------------------

    Assignee: Oleg Ignatenko

> In Ignite code style inspections increase level for those used at Teamcity build checks
> ---------------------------------------------------------------------------------------
>
>                 Key: IGNITE-10450
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10450
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.6
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>         Attachments: IDEA.inspections.TC-bot.obscured.png, IDEA.inspections.TC-bot.png
>
>
> Some of [Ignite code style|https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines]
inspections are verified at Teamcity per IGNITE-9983. (Currently TC inspections are "SizeReplaceableByIsEmpty",
"UnusedImport", "MissingOverrideAnnotation", "MissortedModifiers", "RedundantSuppression".)
> Per discussion of issue IGNITE-10399 it looks like there is a room for improvement here.
Specifically, the problem occurred because it was too difficult to find a new deviation that
made TC inspections check fail because it was buried among multiple similar looking but non-critical
deviations in a particular piece of old code ([PageMemoryImpl.java|https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java]).
> It would be more convenient if programmer could easier see subset of checks that are
used at Teamcity because this would allow to fix these earlier and avoid cumbersome TC runs
and failure reports analysis.
> Technically this could be achieved by editing inspections config file and increasing
respective inspections level to {{ERROR}}. I briefly checked how it would work in a "sandbox"
project on my machine and it looked quite convenient: violations of inspections used by TC
were shown as red in Error Stripe while the rest remained yellow, easy to see. (It's probably
not very important but for the sake of completeness a thing I noticed when testing is that
having red inspections didn't block compilation and execution of the code.) Screen shot of
how it worked in my experiment is attached: [^IDEA.inspections.TC-bot.png]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message