ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-10177) cleanup Junit 3 from the project
Date Sun, 16 Dec 2018 09:39:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722433#comment-16722433
] 

ASF GitHub Bot commented on IGNITE-10177:
-----------------------------------------

GitHub user oignatenko opened a pull request:

    https://github.com/apache/ignite/pull/5678

    experimental code for IGNITE-10177 - do not merge to master

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-10177-experimental

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/5678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5678
    
----
commit ff4699bebf2571cbd648cbf8bccf1e957c7547e5
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-02T23:35:51Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - added @Test
    -- verified with diffs overview

commit a72e24ea010fd7333b7425c349e3de1373aed0fc
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T00:24:34Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit eeeba1cc2f9d9dc02065c19c7c1079008bf73e00
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T00:26:13Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 9304b5f31ef712708be7d04b68a963d8bf4b050d
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T00:29:51Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 7eaf7a0252fb347f19d192859c410c3c29f7c4b6
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T00:39:54Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit eaee42ebf611c1617993177d6466e81399c3ebdc
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T00:48:56Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 62738a3820d4057a9c34ad8b2c6e85959ebfc67e
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T00:57:00Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit afb495f9e97e6e15b0c4c29f6d57dd2bbd569f1c
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T08:39:38Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 3b56b742b52a516a4244d2a07635a99d9abeba18
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T09:06:45Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 3835772a72a99882f9d6cd2557001c9db94ed416
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T09:31:45Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit ac6be2c4e07748f34da5d83ce3e9f20786ead2fc
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T10:46:59Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 9f663a9c857f76fcb0e56c194cc2d6ec10f6888b
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T11:13:26Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit e2eae3201a88c3d9800b9964ce9ca4096ed3d85f
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T11:31:35Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit f9ccc80de28fb2fc64c96d695f5f906a8cd9a946
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T12:40:21Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 3eadd0abf6f58a0a3d8fe8464bb08879d412bca1
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T13:33:00Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 28d9f854993cb99867803cfe0126cf723e071cc5
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T13:54:52Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit ed54719377f694d0111740c0bbd92dcf5294e6c6
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T14:10:26Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit fb97a8c23881d1d1c50423dcea6ac519a36c195a
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T14:26:19Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 063f7ae0164924a775b4235ebd0f704017bc2c73
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T14:45:00Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 17e86cb29c3f3accc65d464a0e0de4f4eac6a19e
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T15:05:01Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 339cca95c36d0e6e738d1b90b14819b3bb57a145
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T15:16:39Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 0d6e815009e625e9104d055cfd6e9dbd88c2625b
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T16:14:32Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 3745f9aed4f94eee7e52b2700bbf9d280abbace1
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T16:27:15Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 9d97abad919a95c7686e0a6520682a76835c5ebf
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T16:37:48Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 7f8e9cf1ad91fa60b592399a14f5d077403f4f04
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T16:48:02Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 4525bc8b9108db183702f73e54d363452a497968
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T17:02:40Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 81d83aacf75a1d73615581ba50ecc9ddaa5eac33
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T17:07:26Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 63525f674d1927566ae5c8aba481c0d82aafc52b
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T17:24:32Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 3f2c9ebe8c1423ab09778da1b74ed0b9cd42aa5a
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T17:42:44Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

commit 13c75f82aa1cbbdd1727217a99f0139c1e9f9592
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-12-03T17:53:38Z

    IGNITE-10175 migrate core module tests from Junit 3 to 4
    - wip - migrating
    -- verified with diffs overview

----


> cleanup Junit 3 from the project
> --------------------------------
>
>                 Key: IGNITE-10177
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10177
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>
> If needed, refer parent task for more details.
>  # remove Junit3-specific parts of API of GridAbstractTest and its subclasses
>  # remove dependencies from Junit 3 in Maven (if there are any)
>  # migrate tests that were missed at prior steps for various reasons:
>  ## untangle design of {{IgnitePdsContinuousRestartTest}} and its subclass which currently
conflict with Junit4 execution because of using constructors and make them properly use {{@Test}}
annotation
>  ## find out why {{WalCompactionTest.testCompressorToleratesEmptyWalSegmentsFsync}} appears
to start running slow / timing out after adding Junit 4 annotations (reproduced this on teamcity
and locally as was discovered in IGNITE-10175)
>  ## find out why {{IgniteTwitterStreamerTest}} runs fine under JUnit 3 but starts failing
after move to JUnit 4
>  ## IgniteCachePartitionedQuerySelfTest, IgniteCacheReplicatedQueryP2PDisabledSelfTest,
ComputeUtilsTest, CacheBasedDatasetBuilderTest, CacheBasedDatasetTest, GridPartitionedCacheJtaLookupClassNameSelfTest,
GridReplicatedCacheJtaLookupClassNameSelfTest (there were problems migrating these at IGNITE-10176)
> # in tests suite classes, change {{extends TestSuite}} to either {{@RunWith(AllTests.class)}}
or {{@Suite.SuiteClasses}}
> # find and update all Junit3-specific code that {{extends TestCase}}
> # execute junit related inspections of IDE and analyse results
> # remove redundant references to {{JUnit4.class}} if there are any (like in {{@RunWith(JUnit4.class)}})
>   (per discussion with [~EdShangGG] it looks more convenient to do this in a separate
ticket for smoother merges)
> Side note if for some reason it turns out critically important to keep test suites names
(by default Junit 4 will use suite class names instead), approach with custom description
annotation [described here|https://stackoverflow.com/questions/34745080/is-it-possible-to-name-a-test-suite-in-junit-4/34745518]
can be used to address that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message