ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Ignatenko (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (IGNITE-10177) cleanup Junit 3 from the project
Date Fri, 07 Dec 2018 13:46:00 GMT

     [ https://issues.apache.org/jira/browse/IGNITE-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Ignatenko updated IGNITE-10177:
------------------------------------
    Description: 
If needed, refer parent task for more details.

# remove deprecated API of GridAbstractTest and its subclasses 
# remove dependencies from Junit 3 in Maven
# migrate tests that were missed at prior steps, if there are any
# remove redundant references to {{JUnit4.class}} if there are any (like in {{@RunWith(JUnit4.class)}})
# in tests suite classes, change {{extends TestSuite}} to either {{@RunWith(AllTests.class)}}
or {{@Suite.SuiteClasses}}
# check and adjust if needed methods like {{GridTestUtils.addTestIfNeeded}} to add the class
via Junit4 adapter
# find and update all Junit3-specific code that {{extends TestCase}}
# untangle design of {{IgnitePdsContinuousRestartTest}} and its subclass which currently conflict
with Junit4 execution because of using constructors and make them properly use {{@Test}} annotation
# review and if possible upgade all occurrences of {{import org.junit}} in the project

Side note if for some reason it turns out critically important to keep test suites names (by
default Junit 4 will use suite class names instead), approach with custom description annotation
[described here|https://stackoverflow.com/questions/34745080/is-it-possible-to-name-a-test-suite-in-junit-4/34745518]
can be used to address that.

  was:
If needed, refer parent task for more details.

# remove deprecated API of GridAbstractTest and its subclasses 
# remove dependencies from Junit 3 in Maven
# migrate tests that were missed at prior steps, if there are any
# remove redundant references to {{JUnit4.class}} if there are any (like in {{@RunWith(JUnit4.class)}})
# in tests suite classes, change {{extends TestSuite}} to either {{@RunWith(AllTests.class)}}
or {{@Suite.SuiteClasses}}
# check and adjust if needed methods like {{GridTestUtils.addTestIfNeeded}} to add the class
via Junit4 adapter
# find and update all Junit3-specific code that {{extends TestCase}}
# untangle design of {{IgnitePdsContinuousRestartTest}} and its subclass which currently conflict
with Junit4 execution because of using constructors and make them properly use {{@Test}} annotation

Side note if for some reason it turns out critically important to keep test suites names (by
default Junit 4 will use suite class names instead), approach with custom description annotation
[described here|https://stackoverflow.com/questions/34745080/is-it-possible-to-name-a-test-suite-in-junit-4/34745518]
can be used to address that.


> cleanup Junit 3 from the project
> --------------------------------
>
>                 Key: IGNITE-10177
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10177
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Oleg Ignatenko
>            Priority: Major
>
> If needed, refer parent task for more details.
> # remove deprecated API of GridAbstractTest and its subclasses 
> # remove dependencies from Junit 3 in Maven
> # migrate tests that were missed at prior steps, if there are any
> # remove redundant references to {{JUnit4.class}} if there are any (like in {{@RunWith(JUnit4.class)}})
> # in tests suite classes, change {{extends TestSuite}} to either {{@RunWith(AllTests.class)}}
or {{@Suite.SuiteClasses}}
> # check and adjust if needed methods like {{GridTestUtils.addTestIfNeeded}} to add the
class via Junit4 adapter
> # find and update all Junit3-specific code that {{extends TestCase}}
> # untangle design of {{IgnitePdsContinuousRestartTest}} and its subclass which currently
conflict with Junit4 execution because of using constructors and make them properly use {{@Test}}
annotation
> # review and if possible upgade all occurrences of {{import org.junit}} in the project
> Side note if for some reason it turns out critically important to keep test suites names
(by default Junit 4 will use suite class names instead), approach with custom description
annotation [described here|https://stackoverflow.com/questions/34745080/is-it-possible-to-name-a-test-suite-in-junit-4/34745518]
can be used to address that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message