ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9542) [TC bot] provide separated base/current branch history for PR page
Date Mon, 10 Dec 2018 16:41:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715049#comment-16715049
] 

ASF GitHub Bot commented on IGNITE-9542:
----------------------------------------

dspavlov commented on a change in pull request #95: IGNITE-9542: new run history stripe
URL: https://github.com/apache/ignite-teamcity-bot/pull/95#discussion_r240287246
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/issue/IssueDetector.java
 ##########
 @@ -446,9 +463,9 @@ protected String checkFailuresEx(String brachName) {
                         backgroundOpsCreds
                 );
 
-        registerIssuesAndNotifyLater(failures, backgroundOpsCreds);
+        String issResult = registerIssuesAndNotifyLater(failures, backgroundOpsCreds);
 
 Review comment:
   Yes, I agree, but this string will go to the monitoring, so it is better to see null showing
there is some unexpected behavior there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [TC bot] provide separated base/current branch history for PR page
> ------------------------------------------------------------------
>
>                 Key: IGNITE-9542
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9542
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Dmitriy Pavlov
>            Assignee: Dmitriy Pavlov
>            Priority: Major
>
> https://issues.apache.org/jira/browse/IGNITE-9376
> works incorrectly without separation of test history for the base and for a shown branch.
> It is suggested to refactor provided data for the current and for the base branch.
> It will allow showing blockers based on statistics from any base branch without relation
with the previous quering of data.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message