ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rodion (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-8558) Provide an opportunity to stop grids and cancel tasks after execution all tests
Date Sat, 29 Dec 2018 09:20:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730613#comment-16730613
] 

Rodion commented on IGNITE-8558:
--------------------------------

I changed flag stopAllGrids(false) on true in teardown(), because it does'n influence on tests
result. And I deleted all usage of stopAllGrids(true) in afterTestsStopped(), because it
duplicates code.

> Provide an opportunity to stop grids and cancel tasks after execution all tests
> -------------------------------------------------------------------------------
>
>                 Key: IGNITE-8558
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8558
>             Project: Ignite
>          Issue Type: Sub-task
>    Affects Versions: 2.6
>            Reporter: Maxim Muzafarov
>            Assignee: Rodion
>            Priority: Minor
>             Fix For: 2.8
>
>
> The -IGNITE-6842- issue provides an ability gracefully shutdown all ignite instances
by default after execution of tests. Ignite instances are stopped by calling the method -
{{stopAllGrids}} ({{cancel = false}} is used). You can refer to these lines of code for the
details of how the node stopped:
> {code:java|title=GridAbstractTest.java:1789}
>  if (isSafeTopology()) {
>      stopAllGrids(false);
>      if (stopGridErr) {
>          err = new RuntimeException("Not all Ignite instances has been stopped. " +
>              "Please, see log for details.", err);
>      }
>  }
> {code}
> As part of IGNITE-8266 a lot of boilerplate code have been successfully removed. For
instance,
> {code:java}
> /** {@inheritDoc} */
> @Override protected void afterTestsStopped() throws Exception {
>     super.afterTestsStopped();
>     stopAllGrids();
> }
> {code}
> We need to,
>  * Provide the ability to override the behaviour of gracefully instance shutdown and
use {{stopAllGirds(true)}} after all tests execution. Assume a new method would be introduced
like {{GridAbstractTest#isSafeTopology}}, so the behaviour can be overridden in subclasses.
>  * Remove the other boilerplate parts of the code. For instance,
> {code:java}
> /** {@inheritDoc} */
> @Override protected void afterTestsStopped() throws Exception {
>     stopAllGrids(true);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message