From issues-return-83909-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Nov 30 11:33:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5E7A1180671 for ; Fri, 30 Nov 2018 11:33:03 +0100 (CET) Received: (qmail 38373 invoked by uid 500); 30 Nov 2018 10:33:02 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 38364 invoked by uid 99); 30 Nov 2018 10:33:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2018 10:33:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 06CACC8102 for ; Fri, 30 Nov 2018 10:33:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wyO39rblA8PA for ; Fri, 30 Nov 2018 10:33:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D8EE260D32 for ; Fri, 30 Nov 2018 10:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 777A1E12FE for ; Fri, 30 Nov 2018 10:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2177E24DD6 for ; Fri, 30 Nov 2018 10:33:00 +0000 (UTC) Date: Fri, 30 Nov 2018 10:33:00 +0000 (UTC) From: "Pavel Kovalenko (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (IGNITE-10493) Refactor exchange stages time measurements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Pavel Kovalenko created IGNITE-10493: ---------------------------------------- Summary: Refactor exchange stages time measurements Key: IGNITE-10493 URL: https://issues.apache.org/jira/browse/IGNITE-10493 Project: Ignite Issue Type: Improvement Components: cache Affects Versions: 2.7 Reporter: Pavel Kovalenko Fix For: 2.8 At the current implementation, we don't cover and measure all possible code executions that influence on PME time. Instead of it we just measure the hottest separate parts with the following hardcoded pattern: {noformat} long time = currentTime(); ... // some code block print ("Stage name performed in " + (currentTime() - time)); {noformat} This approach can be improved. Instead of declaring time variable and print the message to log immediately we can introduce a utility class (TimesBag) that will hold all stages and their times. The content of TimesBag can be printed when the exchange future is done. As exchange is a linear process that executes init stage by exchange-worker and finish stage by one of the sys thread we can easily cover all exchange code base by time cutoffs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)