From issues-return-82774-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Nov 21 10:59:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 055BE180668 for ; Wed, 21 Nov 2018 10:59:04 +0100 (CET) Received: (qmail 72189 invoked by uid 500); 21 Nov 2018 09:59:04 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 72180 invoked by uid 99); 21 Nov 2018 09:59:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Nov 2018 09:59:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AC2D5D214F for ; Wed, 21 Nov 2018 09:59:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id WY4_F_baukQ8 for ; Wed, 21 Nov 2018 09:59:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8BF5D5F529 for ; Wed, 21 Nov 2018 09:59:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B2E39E2613 for ; Wed, 21 Nov 2018 09:59:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3003D21EE3 for ; Wed, 21 Nov 2018 09:59:00 +0000 (UTC) Date: Wed, 21 Nov 2018 09:59:00 +0000 (UTC) From: "Vladimir Ozerov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (IGNITE-9777) Gathering local node IO statistics with cache and index dimensions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693201#comment-16693201 ] Vladimir Ozerov edited comment on IGNITE-9777 at 11/21/18 9:58 AM: ------------------------------------------------------------------- [~jooger], my comments: 1) IoStatisticsQueryHelper - unused methods, should be removed? 2) IoStatisticsHolderIndex.HASH_PK_IDX_NAME - "PK" as name might be confusing because we also have PK index in SQL. I would rename it to "HASH_PK" instead. 3) IoStatisticsHolderIndex#toString - why not using S.toString() instead? IoStatisticsHolderCache#toString - same thing. IoStatisticsHolderQuery - but here we do not have "toString" at all, why? 4) IoStatisticsManager.statsSince - why local and not UTC time? 5) IoStatisticsMetricsMXBean: "getStartGatheringStatistics" -> "getStartTime". Please make sure that LocalDateTime displayed correctly in JConsole or any other JMX tool 6) IoStatisticsMetricsMXBean: "resetStatistics" -> "reset" 7) IoStatisticsMetricsMXBean: "getCacheStatisticsFormatted" -> "getCacheGroupStatistics", "getCachePhysicalReadsStatistics" -> "getCacheGroupPhysicalReads", "getCacheLogicalReadsStatistics" -> "getCacheGroupLogicalReads" 8) Same as p.7 but for indexes. 9) "getStatHashIndexesNames", "getStatSortedIndexesNames", "getStatCachesNames" - I do not think we need this at all. It is better to simply list available constants in docs. 10) IoStatisticsMetricsMXBean.getCachePhysicalReadsStatistics, getIndexPhysicalReadsStatistics, getIndexLeafPhysicalReadsStatistics, getIndexInnerPhysicalReadsStatistics -> looks like these methods are never tested. was (Author: vozerov): [~jooger], my comments: 1) IoStatisticsQueryHelper - unused methods, should be removed? 2) IoStatisticsHolderIndex.HASH_PK_IDX_NAME - "PK" as name might be confusing because we also have PK index in SQL. I would rename it to "HASH_PK" instead. 3) IoStatisticsHolderIndex#toString - why not using S.toString() instead? IoStatisticsHolderCache#toString - same thing. IoStatisticsHolderQuery - but here we do not have "toString" at all, why? 4) IoStatisticsManager.statsSince - why local and not UTF time? 5) IoStatisticsMetricsMXBean: "getStartGatheringStatistics" -> "getStartTime". Please make sure that LocalDateTime displayed correctly in JConsole or any other JMX tool 6) IoStatisticsMetricsMXBean: "resetStatistics" -> "reset" 7) IoStatisticsMetricsMXBean: "getCacheStatisticsFormatted" -> "getCacheGroupStatistics", "getCachePhysicalReadsStatistics" -> "getCacheGroupPhysicalReads", "getCacheLogicalReadsStatistics" -> "getCacheGroupLogicalReads" 8) Same as p.7 but for indexes. 9) "getStatHashIndexesNames", "getStatSortedIndexesNames", "getStatCachesNames" - I do not think we need this at all. It is better to simply list available constants in docs. 10) IoStatisticsMetricsMXBean.getCachePhysicalReadsStatistics, getIndexPhysicalReadsStatistics, getIndexLeafPhysicalReadsStatistics, getIndexInnerPhysicalReadsStatistics -> looks like these methods are never tested. > Gathering local node IO statistics with cache and index dimensions > ------------------------------------------------------------------ > > Key: IGNITE-9777 > URL: https://issues.apache.org/jira/browse/IGNITE-9777 > Project: Ignite > Issue Type: Task > Components: persistence, sql > Reporter: Yury Gerzhedovich > Assignee: Yury Gerzhedovich > Priority: Major > Labels: iep-27 > Fix For: 2.8 > > > Should be gathered and exposed IO statistics on cache/index level. -- This message was sent by Atlassian JIRA (v7.6.3#76005)