ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Muzafarov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-10493) Refactor exchange stages time measurements
Date Fri, 30 Nov 2018 14:14:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704784#comment-16704784

Maxim Muzafarov commented on IGNITE-10493:

Hello, Pavel!

I think we should extend our JMX metrics (for instance, create a new Bean) and allow external
tools to collect and aggregate these metrics regarding to exchange stages.

WDYT? Will it be a good idea?

> Refactor exchange stages time measurements
> ------------------------------------------
>                 Key: IGNITE-10493
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10493
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache
>    Affects Versions: 2.7
>            Reporter: Pavel Kovalenko
>            Priority: Major
>             Fix For: 2.8
> At the current implementation, we don't cover and measure all possible code executions
that influence on PME time. Instead of it we just measure the hottest separate parts with
the following hardcoded pattern:
> {noformat}
> long time = currentTime();
> ... // some code block
> print ("Stage name performed in " + (currentTime() - time));
> {noformat}
> This approach can be improved. Instead of declaring time variable and print the message
to log immediately we can introduce a utility class (TimesBag) that will hold all stages and
their times. The content of TimesBag can be printed when the exchange future is done.
> As exchange is a linear process that executes init stage by exchange-worker and finish
stage by one of the sys thread we can easily cover all exchange code base by time cutoffs.

This message was sent by Atlassian JIRA

View raw message