ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-10190) [TC Bot] Failed tests don't count as blockers if they were created in the PR
Date Sat, 10 Nov 2018 10:22:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682323#comment-16682323
] 

ASF GitHub Bot commented on IGNITE-10190:
-----------------------------------------

asfgit closed pull request #62: IGNITE-10190 Failed tests don't count as blockers (if created
in the PR)
URL: https://github.com/apache/ignite-teamcity-bot/pull/62
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
index dbee4f72..c3c28a36 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
@@ -235,11 +235,14 @@ public void initStat(@Nullable final Function<TestInBranch, RunStat>
runStatSupp
      * @return {@code True} if this failure is appeared in the current branch.
      */
     public boolean isNewFailedTest() {
-        FailureSummary recent = histBaseBranch.recent;
-
         if (!Strings.isNullOrEmpty(webIssueUrl))
             return false;
 
+        if (histBaseBranch.latestRuns == null)
+            return true;
+
+        FailureSummary recent = histBaseBranch.recent;
+
         boolean lowFailureRate = recent != null && recent.failureRate != null &&
             Float.valueOf(recent.failureRate.replace(',', '.')) < 4.;
 
diff --git a/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js b/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
index 037a7203..82622762 100644
--- a/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
+++ b/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
@@ -693,12 +693,12 @@ function showSuiteData(suite, settings) {
  * @returns {boolean} True - if test is new. False - otherwise.
  */
 function isNewFailedTest(testFail) {
-    if(!isDefinedAndFilled(testFail.histBaseBranch))
-        return true;
-
     if (isDefinedAndFilled(testFail.webIssueUrl))
         return false;
 
+    if (!isDefinedAndFilled(testFail.histBaseBranch) || !isDefinedAndFilled(testFail.histBaseBranch.latestRuns))
+        return true;
+
     var hist = testFail.histBaseBranch;
 
     if (!isDefinedAndFilled(hist.recent))
@@ -995,4 +995,4 @@ function initMoreInfo() {
             });
         });
     });
-}
\ No newline at end of file
+}


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [TC Bot] Failed tests don't count as blockers if they were created in the PR
> ----------------------------------------------------------------------------
>
>                 Key: IGNITE-10190
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10190
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Ryabov Dmitrii
>            Assignee: Ryabov Dmitrii
>            Priority: Major
>
> Failed tests don't count as blockers if they were created in the PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message