ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ignite TC Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-10158) Some tests in IgniteCacheAbstractQuerySelfTest are incorrectly muted
Date Fri, 09 Nov 2018 17:36:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681737#comment-16681737
] 

Ignite TC Bot commented on IGNITE-10158:
----------------------------------------

{panel:title=No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity Run All Results|http://ci.ignite.apache.org/viewLog.html?buildId=2279715&amp;buildTypeId=IgniteTests24Java8_RunAll]

> Some tests in IgniteCacheAbstractQuerySelfTest are incorrectly muted
> --------------------------------------------------------------------
>
>                 Key: IGNITE-10158
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10158
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.6
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>             Fix For: 2.8
>
>
> Some tests in [IgniteCacheAbstractQuerySelfTest|https://github.com/apache/ignite/blob/master/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractQuerySelfTest.java]
are muted by renaming (prefixing with underscore, {{_test...}} and refer invalid JIRA URL
in fail parameter ("http://atlassian.gridgain.com/jira/browse/GG-11216").
> - _testDifferentKeyTypes
>   this test should change expectation to opposite and after that recovered
> - _testObjectQueryWithSwap and _testTwoObjectsTextSearch
>   Need to be properly muted and further investigated, per separate tickets. Per my preliminary
checks tests fail because
>   of wrong cache configuration, although there is also a chance that test design is wrong
and these should be deleted.
> There is also a dead code there, a private class {{EmptyObject}} - it needs to be deleted.
Code that was using this class was removed per [IGNITE-1232|https://issues.apache.org/jira/browse/IGNITE-1232]
([commit 79b8b08|https://github.com/gridgain/apache-ignite/commit/68891e89dd0e0f19321d6a4d45ae7372279b8b08#diff-a2f35b3aa70a70b98ce0cd6a1381d1f7])
but this private class was forgotten.
> I also searched project code for other occurrences of mentioned troublesome fail parameter
"GG-11216" and found yet another incorrectly muted test: {{IgniteCacheQueryMultiThreadedSelfTest#_testMultiThreadedSwapUnswapLongString}}
>  This test should be recovered. It passed on my machine and per my comparison with similar
test cases {{testMultiThreadedSwapUnswapLong}} and {{testMultiThreadedSwapUnswapString}} its
design looks fairly reasonable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message