ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-10158) Some tests in IgniteCacheAbstractQuerySelfTest are incorrectly muted
Date Wed, 07 Nov 2018 14:23:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678282#comment-16678282
] 

ASF GitHub Bot commented on IGNITE-10158:
-----------------------------------------

GitHub user oignatenko opened a pull request:

    https://github.com/apache/ignite/pull/5344

    IGNITE-10158 Some tests in IgniteCacheAbstractQuerySelfTest are incorrectly muted

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-10158

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/5344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5344
    
----
commit fa7662e7fbc410a5064815f16838e0ef91b0683b
Author: Alexey Platonov <aplatonovv@...>
Date:   2018-11-07T11:53:58Z

    init commit

commit 2afea369eaf285c3d42c377c46161a5041ab0bb0
Author: Alexey Platonov <aplatonovv@...>
Date:   2018-11-07T11:56:23Z

    Merge branch 'master' of https://github.com/apache/ignite into ignite-10159

commit ac6414e0c5a2e2b6fe75b6b170fb988421ca1c5d
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-11-07T14:14:22Z

    IGNITE-10158 Some tests in IgniteCacheAbstractQuerySelfTest are incorrectly muted
    - fixed as suggested in the ticket
    -- verified with diffs overview, clean rebuild and trial execution of modified tests on
my machine

----


> Some tests in IgniteCacheAbstractQuerySelfTest are incorrectly muted
> --------------------------------------------------------------------
>
>                 Key: IGNITE-10158
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10158
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.6
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>             Fix For: 2.8
>
>
> Some tests in [IgniteCacheAbstractQuerySelfTest|https://github.com/apache/ignite/blob/master/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractQuerySelfTest.java]
are muted by renaming (prefixing with underscore, {{_test...}} and refer invalid JIRA URL
in fail parameter ("http://atlassian.gridgain.com/jira/browse/GG-11216").
> - _testDifferentKeyTypes
>   this test should change expectation to opposite and after that recovered
> - _testObjectQueryWithSwap and _testTwoObjectsTextSearch
>   Need to be properly muted and further investigated, per separate tickets. Per my preliminary
checks tests fail because
>   of wrong cache configuration, although there is also a chance that test design is wrong
and these should be deleted.
> There is also a dead code there, a private class {{EmptyObject}} - it needs to be deleted.
Code that was using this class was removed per [IGNITE-1232|https://issues.apache.org/jira/browse/IGNITE-1232]
([commit 79b8b08|https://github.com/gridgain/apache-ignite/commit/68891e89dd0e0f19321d6a4d45ae7372279b8b08#diff-a2f35b3aa70a70b98ce0cd6a1381d1f7])
but this private class was forgotten.
> I also searched project code for other occurrences of mentioned troublesome fail parameter
"GG-11216" and found yet another incorrectly muted test: {{IgniteCacheQueryMultiThreadedSelfTest#_testMultiThreadedSwapUnswapLongString}}
>  This test should be recovered. It passed on my machine and per my comparison with similar
test cases {{testMultiThreadedSwapUnswapLong}} and {{testMultiThreadedSwapUnswapString}} its
design looks fairly reasonable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message