ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-10115) Remove excessive "setAccessible(oldAccessible)" in GridTestUtils
Date Thu, 01 Nov 2018 14:31:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671678#comment-16671678

ASF GitHub Bot commented on IGNITE-10115:

GitHub user ibessonov opened a pull request:


    IGNITE-10115 Remove excessive "setAccessible(oldAccessible)" in GridTestUtils


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-10115

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5235
commit 47693921dcbd81709d68289eb6133bf17048928b
Author: ibessonov <bessonov.ip@...>
Date:   2018-11-01T14:29:14Z

    IGNITE-10115 Removed excessive "setAccessible" invocations.


> Remove excessive "setAccessible(oldAccessible)" in GridTestUtils
> ----------------------------------------------------------------
>                 Key: IGNITE-10115
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10115
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Ivan Bessonov
>            Assignee: Ivan Bessonov
>            Priority: Major
>             Fix For: 2.8
> Methods likeĀ org.apache.ignite.testframework.GridTestUtils#setFieldValue(java.lang.Object,
java.lang.String, java.lang.Object) return old state of Field objects but that doesn't make
any sense. Removing such actions will make code more clear and effective.

This message was sent by Atlassian JIRA

View raw message