ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Bessonov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9902) ScanQuery doesn't take lost partitions into account
Date Mon, 26 Nov 2018 14:58:01 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699075#comment-16699075
] 

Ivan Bessonov commented on IGNITE-9902:
---------------------------------------

[~aplatonov] Upsource doesn't work now so I'll leave my comments here:
 * Please use GridTestUtils#assertThrows, your code simply doesn't work as you expect. Usage
of existing methods will help you to avoid such problems ("return" in line 833).
 * There's not enough empty lines in the same method ("checkQueryFails"), please reformat
your code.
 * You attached TC results but ignored fails caused by your changes. I'm talking about this
particular error: [InspectionsCore|https://ci.ignite.apache.org/viewLog.html?buildId=2377689&tab=Inspection&buildTypeId=IgniteTests24Java8_InspectionsCore]
 * "Query should was fallen" doesn't look grammatically correct, but I expect it to be removed
anyway.
 * Please rerun TC after your further changes and only then move the issue to the "Patch Available"
status, thank you!

 

> ScanQuery doesn't take lost partitions into account
> ---------------------------------------------------
>
>                 Key: IGNITE-9902
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9902
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Stanislav Lukyanov
>            Assignee: Alexey Platonov
>            Priority: Major
>          Time Spent: 8h
>  Remaining Estimate: 0h
>
> Same as IGNITE-9841, but about scan queries.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message