ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilya Lantukh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9883) Do not block get/getAll during start/stop operations on other cache.
Date Tue, 06 Nov 2018 15:23:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676888#comment-16676888
] 

Ilya Lantukh commented on IGNITE-9883:
--------------------------------------

[~ibessonov], thanks for the contribution!

I have reviewed your pull request and see 2 problems:
1. Your solution only works in situation when DHT has already received discovery event for
the next topology version. What if it hasn't? The first problem is that we will have to wait
for it. The second is that even after we received that event, all cache messages that were
received earlier will continue to wait until exchange is finished. I don't think that we can
consider this ticket complete without fixing at least the second problem.
2. Currently shouldWaitForAffinityReadyFuture(...) always returns true if versions are equal,
without taking event type into consideration. It looks dangerous to me, I suggest to restrict
it to DynamicCacheChange events.

> Do not block get/getAll during start/stop operations on other cache.
> --------------------------------------------------------------------
>
>                 Key: IGNITE-9883
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9883
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Ivan Bessonov
>            Assignee: Ivan Bessonov
>            Priority: Major
>             Fix For: 2.8
>
>
> Do not block get/getAll during start/stop operations on other cache.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message